gemma: pkg/controllers/importconfig.go annotate

annotate pkg/controllers/importconfig.go @ 3678:8f58851927c0

client: make layer factory only return new layer config for individual maps instead of each time it is invoked. The purpose of the factory was to support multiple maps with individual layers. But returning a new config each time it is invoked leads to bugs that rely on the layer's state. Now this factory reuses the same objects it created before, per map.

author	Markus Kottlaender <markus@intevation.de>
date	Mon, 17 Jun 2019 17:31:35 +0200
parents	efa468653d48
children	8af156928a2d

rev	line source
1582 dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	1 // This is Free Software under GNU Affero General Public License v >= 3.0
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	2 // without warranty, see README.md and license for details.
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	3 //
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	4 // SPDX-License-Identifier: AGPL-3.0-or-later
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	5 // License-Filename: LICENSES/AGPL-3.0.txt
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	6 //
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	7 // Copyright (C) 2018 by via donau
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	8 // – Österreichische Wasserstraßen-Gesellschaft mbH
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	9 // Software engineering by Intevation GmbH
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	10 //
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	11 // Author(s):
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	12 // * Sascha L. Teichmann <sascha.teichmann@intevation.de>
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	13
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	14 package controllers
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	15
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	16 import (
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	17 "database/sql"
2051 7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	18 "encoding/json"
2046 725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	19 "fmt"
1582 dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	20 "net/http"
2045 10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	21 "strconv"
10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	22
10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	23 "github.com/gorilla/mux"
10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	24
2051 7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	25 "gemma.intevation.de/gemma/pkg/auth"
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	26 "gemma.intevation.de/gemma/pkg/common"
2045 10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	27 "gemma.intevation.de/gemma/pkg/imports"
2050 a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	28 "gemma.intevation.de/gemma/pkg/scheduler"
1583 caedd9b176f2 Added GET to /api/imports/scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1582 diff changeset	29 )
caedd9b176f2 Added GET to /api/imports/scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1582 diff changeset	30
1730 7c54babe10f7 Configured imports: Added GET /imports/config/{id:[0-9]+}/run" to run a configured import. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1727 diff changeset	31 func runImportConfig(
7c54babe10f7 Configured imports: Added GET /imports/config/{id:[0-9]+}/run" to run a configured import. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1727 diff changeset	32 _ interface{},
7c54babe10f7 Configured imports: Added GET /imports/config/{id:[0-9]+}/run" to run a configured import. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1727 diff changeset	33 req *http.Request,
1748 c11807dc6940 Comfigured imports: Run enqueing of configured imports if triggered by REST with the database connection of the logged in user. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1739 diff changeset	34 conn *sql.Conn,
1730 7c54babe10f7 Configured imports: Added GET /imports/config/{id:[0-9]+}/run" to run a configured import. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1727 diff changeset	35 ) (jr JSONResult, err error) {
7c54babe10f7 Configured imports: Added GET /imports/config/{id:[0-9]+}/run" to run a configured import. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1727 diff changeset	36
2045 10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	37 id, _ := strconv.ParseInt(mux.Vars(req)["id"], 10, 64)
1730 7c54babe10f7 Configured imports: Added GET /imports/config/{id:[0-9]+}/run" to run a configured import. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1727 diff changeset	38
2045 10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	39 ctx := req.Context()
1748 c11807dc6940 Comfigured imports: Run enqueing of configured imports if triggered by REST with the database connection of the logged in user. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1739 diff changeset	40
2045 10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	41 var jobID int64
10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	42 if jobID, err = imports.RunConfiguredImportContext(ctx, conn, id); err != nil {
10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	43 return
10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	44 }
1730 7c54babe10f7 Configured imports: Added GET /imports/config/{id:[0-9]+}/run" to run a configured import. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1727 diff changeset	45
2045 10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	46 var result = struct {
10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	47 ID int64 `json:"id"`
10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	48 }{
10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	49 ID: jobID,
10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	50 }
1730 7c54babe10f7 Configured imports: Added GET /imports/config/{id:[0-9]+}/run" to run a configured import. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1727 diff changeset	51
2045 10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	52 jr = JSONResult{
10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	53 Code: http.StatusCreated,
10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	54 Result: &result,
10a1e139d2e8 Imports: Re-enabled running configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2042 diff changeset	55 }
1730 7c54babe10f7 Configured imports: Added GET /imports/config/{id:[0-9]+}/run" to run a configured import. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1727 diff changeset	56 return
7c54babe10f7 Configured imports: Added GET /imports/config/{id:[0-9]+}/run" to run a configured import. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1727 diff changeset	57 }
7c54babe10f7 Configured imports: Added GET /imports/config/{id:[0-9]+}/run" to run a configured import. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1727 diff changeset	58
1627 b10aa02d7819 Refactored: Moved REST /api/imports/scheduler to /api/imports/config Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1592 diff changeset	59 func modifyImportConfig(
1592 c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	60 input interface{},
c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	61 req *http.Request,
c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	62 conn *sql.Conn,
c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	63 ) (jr JSONResult, err error) {
c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	64
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	65 ctx := req.Context()
1592 c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	66
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	67 raw := input.(*json.RawMessage)
1592 c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	68
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	69 id, _ := strconv.ParseInt(mux.Vars(req)["id"], 10, 64)
2042 d29ac997eb34 This breaks this branch!!!! Starting to remove the old persistent layer for configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2016 diff changeset	70
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	71 var pc *imports.PersistentConfig
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	72 pc, err = imports.LoadPersistentConfigContext(ctx, conn, id)
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	73 switch {
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	74 case err == sql.ErrNoRows:
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	75 err = JSONError{
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	76 Code: http.StatusNotFound,
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	77 Message: fmt.Sprintf("No configuration %d found", id),
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	78 }
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	79 return
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	80 case err != nil:
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	81 return
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	82 }
2042 d29ac997eb34 This breaks this branch!!!! Starting to remove the old persistent layer for configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2016 diff changeset	83
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	84 kind := imports.JobKind(pc.Kind)
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	85 ctor := imports.ImportModelForJobKind(kind)
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	86 if ctor == nil {
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	87 err = JSONError{
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	88 Code: http.StatusInternalServerError,
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	89 Message: fmt.Sprintf("No constructor for kind '%s' found", pc.Kind),
1704 897d4d8316ad Import configuration: Made extra attributes updatable, too. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1702 diff changeset	90 }
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	91 return
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	92 }
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	93 config := ctor()
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	94 if err = json.Unmarshal(*raw, config); err != nil {
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	95 return
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	96 }
2042 d29ac997eb34 This breaks this branch!!!! Starting to remove the old persistent layer for configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2016 diff changeset	97
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	98 _, oldCron := pc.Attributes.Get("cron")
2042 d29ac997eb34 This breaks this branch!!!! Starting to remove the old persistent layer for configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2016 diff changeset	99
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	100 session, _ := auth.GetSession(req)
3552 ffc8fb059d1a refactor password persistence for import configurations. Thomas Junk <thomas.junk@intevation.de> parents: 3549 diff changeset	101 // When a password is stored it doesn't get retransmitted to the client
ffc8fb059d1a refactor password persistence for import configurations. Thomas Junk <thomas.junk@intevation.de> parents: 3549 diff changeset	102 // in order to prevent password leakage
ffc8fb059d1a refactor password persistence for import configurations. Thomas Junk <thomas.junk@intevation.de> parents: 3549 diff changeset	103 // When the user changes the import configuration without a new password
ffc8fb059d1a refactor password persistence for import configurations. Thomas Junk <thomas.junk@intevation.de> parents: 3549 diff changeset	104 // the old password should be conserved
3554 efa468653d48 only write password attribute, when available previous Thomas Junk <thomas.junk@intevation.de> parents: 3552 diff changeset	105 oldPasswd, ok := pc.Attributes["password"]
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	106 pc.User = session.User
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	107 pc.Attributes = common.Attributes{}
3554 efa468653d48 only write password attribute, when available previous Thomas Junk <thomas.junk@intevation.de> parents: 3552 diff changeset	108 if ok == true {
efa468653d48 only write password attribute, when available previous Thomas Junk <thomas.junk@intevation.de> parents: 3552 diff changeset	109 pc.Attributes["password"] = oldPasswd
efa468653d48 only write password attribute, when available previous Thomas Junk <thomas.junk@intevation.de> parents: 3552 diff changeset	110 }
3552 ffc8fb059d1a refactor password persistence for import configurations. Thomas Junk <thomas.junk@intevation.de> parents: 3549 diff changeset	111 pc.Attributes.Marshal(config) // Marshal only overwrites keys present in config
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	112 cron, newCron := pc.Attributes.Get("cron")
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	113
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	114 var tx *sql.Tx
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	115 if tx, err = conn.BeginTx(ctx, nil); err != nil {
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	116 return
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	117 }
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	118 defer tx.Rollback()
1592 c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	119
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	120 if err = pc.UpdateContext(ctx, tx); err != nil {
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	121 return
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	122 }
2042 d29ac997eb34 This breaks this branch!!!! Starting to remove the old persistent layer for configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2016 diff changeset	123
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	124 if oldCron {
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	125 scheduler.UnbindByID(id)
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	126 }
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	127
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	128 if newCron {
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	129 if err = scheduler.BindAction(
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	130 string(pc.Kind),
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	131 cron,
2042 d29ac997eb34 This breaks this branch!!!! Starting to remove the old persistent layer for configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2016 diff changeset	132 id,
1592 c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	133 ); err != nil {
c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	134 return
c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	135 }
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	136 }
1592 c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	137
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	138 if err = tx.Commit(); err != nil {
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	139 return
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	140 }
1592 c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	141
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	142 var result = struct {
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	143 ID int64 `json:"id"`
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	144 }{
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	145 ID: id,
0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	146 }
1592 c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	147
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	148 jr = JSONResult{Result: &result}
1592 c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	149 return
c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	150 }
c12cec1d7692 Added PATCH /imports/scheduler/{id:[0-9]+} to modify a single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1591 diff changeset	151
1627 b10aa02d7819 Refactored: Moved REST /api/imports/scheduler to /api/imports/config Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1592 diff changeset	152 func infoImportConfig(
1591 2d53065c95af Added GET /imports/scheduler/{id:[0-9]+} to show infos about single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1590 diff changeset	153 _ interface{},
2d53065c95af Added GET /imports/scheduler/{id:[0-9]+} to show infos about single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1590 diff changeset	154 req *http.Request,
2d53065c95af Added GET /imports/scheduler/{id:[0-9]+} to show infos about single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1590 diff changeset	155 conn *sql.Conn,
2d53065c95af Added GET /imports/scheduler/{id:[0-9]+} to show infos about single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1590 diff changeset	156 ) (jr JSONResult, err error) {
2d53065c95af Added GET /imports/scheduler/{id:[0-9]+} to show infos about single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1590 diff changeset	157
2046 725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	158 ctx := req.Context()
1591 2d53065c95af Added GET /imports/scheduler/{id:[0-9]+} to show infos about single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1590 diff changeset	159
2046 725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	160 id, _ := strconv.ParseInt(mux.Vars(req)["id"], 10, 64)
1591 2d53065c95af Added GET /imports/scheduler/{id:[0-9]+} to show infos about single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1590 diff changeset	161
2046 725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	162 var cfg *imports.PersistentConfig
1591 2d53065c95af Added GET /imports/scheduler/{id:[0-9]+} to show infos about single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1590 diff changeset	163
2046 725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	164 cfg, err = imports.LoadPersistentConfigContext(ctx, conn, id)
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	165 switch {
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	166 case err != nil:
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	167 return
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	168 case cfg == nil:
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	169 err = JSONError{
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	170 Code: http.StatusNotFound,
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	171 Message: fmt.Sprintf("No schedule %d found", id),
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	172 }
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	173 return
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	174 }
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	175
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	176 kind := imports.JobKind(cfg.Kind)
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	177
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	178 ctor := imports.ImportModelForJobKind(kind)
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	179 if ctor == nil {
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	180 err = JSONError{
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	181 Code: http.StatusInternalServerError,
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	182 Message: fmt.Sprintf("No constructor for kind '%s' found", cfg.Kind),
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	183 }
2052 0b203a3b3e8e Imports: Re-enabled /imports/config/{id} PATCH. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2051 diff changeset	184 return
2046 725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	185 }
2047 78002c5e838c Imports: Code simplification. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2046 diff changeset	186
3515 c64c47ff2ab1 import: fix for passwordleakage. No passwords are received/sent if configuration is edited. Thomas Junk <thomas.junk@intevation.de> parents: 2052 diff changeset	187 // Remove `password` from the attributes to be delivered to the client.
c64c47ff2ab1 import: fix for passwordleakage. No passwords are received/sent if configuration is edited. Thomas Junk <thomas.junk@intevation.de> parents: 2052 diff changeset	188 // Even a priviledged user shall not be able to see the password.
c64c47ff2ab1 import: fix for passwordleakage. No passwords are received/sent if configuration is edited. Thomas Junk <thomas.junk@intevation.de> parents: 2052 diff changeset	189 // (See config.ListAllPersistentConfigurationsContext() for the other
c64c47ff2ab1 import: fix for passwordleakage. No passwords are received/sent if configuration is edited. Thomas Junk <thomas.junk@intevation.de> parents: 2052 diff changeset	190 // place where this is done.)
c64c47ff2ab1 import: fix for passwordleakage. No passwords are received/sent if configuration is edited. Thomas Junk <thomas.junk@intevation.de> parents: 2052 diff changeset	191 filteredAttributes := make(common.Attributes)
c64c47ff2ab1 import: fix for passwordleakage. No passwords are received/sent if configuration is edited. Thomas Junk <thomas.junk@intevation.de> parents: 2052 diff changeset	192 for key, value := range cfg.Attributes {
c64c47ff2ab1 import: fix for passwordleakage. No passwords are received/sent if configuration is edited. Thomas Junk <thomas.junk@intevation.de> parents: 2052 diff changeset	193 if key != "password" {
c64c47ff2ab1 import: fix for passwordleakage. No passwords are received/sent if configuration is edited. Thomas Junk <thomas.junk@intevation.de> parents: 2052 diff changeset	194 filteredAttributes[key] = value
c64c47ff2ab1 import: fix for passwordleakage. No passwords are received/sent if configuration is edited. Thomas Junk <thomas.junk@intevation.de> parents: 2052 diff changeset	195 }
c64c47ff2ab1 import: fix for passwordleakage. No passwords are received/sent if configuration is edited. Thomas Junk <thomas.junk@intevation.de> parents: 2052 diff changeset	196 }
2046 725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	197
3515 c64c47ff2ab1 import: fix for passwordleakage. No passwords are received/sent if configuration is edited. Thomas Junk <thomas.junk@intevation.de> parents: 2052 diff changeset	198 what := ctor()
c64c47ff2ab1 import: fix for passwordleakage. No passwords are received/sent if configuration is edited. Thomas Junk <thomas.junk@intevation.de> parents: 2052 diff changeset	199 if err = filteredAttributes.Unmarshal(what); err != nil {
2047 78002c5e838c Imports: Code simplification. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2046 diff changeset	200 return
2046 725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	201 }
1591 2d53065c95af Added GET /imports/scheduler/{id:[0-9]+} to show infos about single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1590 diff changeset	202
2046 725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	203 jr = JSONResult{Result: &imports.ImportConfigOut{
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	204 ID: id,
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	205 Kind: imports.ImportKind(cfg.Kind),
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	206 Config: what,
725884a4c89a Imports: Re-enabled /imports/config/{id} GET- Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2045 diff changeset	207 }}
1591 2d53065c95af Added GET /imports/scheduler/{id:[0-9]+} to show infos about single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1590 diff changeset	208 return
2d53065c95af Added GET /imports/scheduler/{id:[0-9]+} to show infos about single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1590 diff changeset	209 }
2d53065c95af Added GET /imports/scheduler/{id:[0-9]+} to show infos about single import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1590 diff changeset	210
1627 b10aa02d7819 Refactored: Moved REST /api/imports/scheduler to /api/imports/config Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1592 diff changeset	211 func deleteImportConfig(
1590 2fdd8e57542d Added DELETE /imports/scheduler/{id:[0-9]+} to delete a schedule from the scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1589 diff changeset	212 _ interface{},
2fdd8e57542d Added DELETE /imports/scheduler/{id:[0-9]+} to delete a schedule from the scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1589 diff changeset	213 req *http.Request,
2fdd8e57542d Added DELETE /imports/scheduler/{id:[0-9]+} to delete a schedule from the scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1589 diff changeset	214 conn *sql.Conn,
2fdd8e57542d Added DELETE /imports/scheduler/{id:[0-9]+} to delete a schedule from the scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1589 diff changeset	215 ) (jr JSONResult, err error) {
2fdd8e57542d Added DELETE /imports/scheduler/{id:[0-9]+} to delete a schedule from the scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1589 diff changeset	216
2050 a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	217 ctx := req.Context()
1590 2fdd8e57542d Added DELETE /imports/scheduler/{id:[0-9]+} to delete a schedule from the scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1589 diff changeset	218
2050 a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	219 id, _ := strconv.ParseInt(mux.Vars(req)["id"], 10, 64)
1590 2fdd8e57542d Added DELETE /imports/scheduler/{id:[0-9]+} to delete a schedule from the scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1589 diff changeset	220
2050 a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	221 var tx *sql.Tx
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	222 if tx, err = conn.BeginTx(ctx, nil); err != nil {
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	223 return
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	224 }
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	225 defer tx.Rollback()
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	226
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	227 err = imports.DeletePersistentConfigurationContext(
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	228 ctx,
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	229 tx,
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	230 id,
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	231 )
1704 897d4d8316ad Import configuration: Made extra attributes updatable, too. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1702 diff changeset	232
2050 a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	233 switch {
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	234 case err == sql.ErrNoRows:
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	235 err = JSONError{
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	236 Code: http.StatusNotFound,
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	237 Message: fmt.Sprintf("No configuration %d found", id),
2049 d1a680be7ae4 Imports. Re-enabled /imports/config GET. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2048 diff changeset	238 }
2050 a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	239 return
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	240 case err != nil:
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	241 return
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	242 }
2042 d29ac997eb34 This breaks this branch!!!! Starting to remove the old persistent layer for configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2016 diff changeset	243
2050 a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	244 // Remove from running scheduler.
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	245 scheduler.UnbindByID(id)
2049 d1a680be7ae4 Imports. Re-enabled /imports/config GET. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2048 diff changeset	246
2050 a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	247 if err = tx.Commit(); err != nil {
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	248 return
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	249 }
1590 2fdd8e57542d Added DELETE /imports/scheduler/{id:[0-9]+} to delete a schedule from the scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1589 diff changeset	250
2050 a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	251 var result = struct {
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	252 ID int64 `json:"id"`
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	253 }{
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	254 ID: id,
a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	255 }
1590 2fdd8e57542d Added DELETE /imports/scheduler/{id:[0-9]+} to delete a schedule from the scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1589 diff changeset	256
2050 a3ccef8ec304 Imports: Re-enabled /imports/config/{id} DELETE. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2049 diff changeset	257 jr = JSONResult{Result: &result}
2042 d29ac997eb34 This breaks this branch!!!! Starting to remove the old persistent layer for configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2016 diff changeset	258
1590 2fdd8e57542d Added DELETE /imports/scheduler/{id:[0-9]+} to delete a schedule from the scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1589 diff changeset	259 return
2fdd8e57542d Added DELETE /imports/scheduler/{id:[0-9]+} to delete a schedule from the scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1589 diff changeset	260 }
2fdd8e57542d Added DELETE /imports/scheduler/{id:[0-9]+} to delete a schedule from the scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1589 diff changeset	261
1627 b10aa02d7819 Refactored: Moved REST /api/imports/scheduler to /api/imports/config Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1592 diff changeset	262 func addImportConfig(
1589 e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	263 input interface{},
e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	264 req *http.Request,
e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	265 conn *sql.Conn,
e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	266 ) (jr JSONResult, err error) {
e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	267
2051 7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	268 cfg := input.(*imports.ImportConfigIn)
1589 e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	269
2051 7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	270 kind := imports.JobKind(cfg.Kind)
1589 e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	271
2051 7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	272 ctor := imports.ImportModelForJobKind(kind)
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	273 if ctor == nil {
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	274 err = JSONError{
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	275 Code: http.StatusBadRequest,
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	276 Message: fmt.Sprintf("No kind %s found", string(cfg.Kind)),
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	277 }
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	278 return
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	279 }
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	280 config := ctor()
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	281 if err = json.Unmarshal(cfg.Config, config); err != nil {
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	282 return
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	283 }
1589 e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	284
2051 7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	285 session, _ := auth.GetSession(req)
1589 e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	286
2051 7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	287 pc := imports.PersistentConfig{
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	288 User: session.User,
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	289 Kind: string(cfg.Kind),
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	290 Attributes: common.Attributes{},
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	291 }
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	292 pc.Attributes.Marshal(config)
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	293
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	294 ctx := req.Context()
1589 e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	295
2051 7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	296 var tx *sql.Tx
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	297 if tx, err = conn.BeginTx(ctx, nil); err != nil {
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	298 return
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	299 }
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	300 defer tx.Rollback()
1702 49b89575ab31 Import configuration: [WIP] Added table for extra configuration attributes. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1654 diff changeset	301
2051 7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	302 var id int64
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	303 if id, err = pc.StoreContext(ctx, tx); err != nil {
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	304 return
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	305 }
2042 d29ac997eb34 This breaks this branch!!!! Starting to remove the old persistent layer for configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2016 diff changeset	306
2051 7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	307 // Need to start a scheduler job right away?
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	308 if cron, ok := pc.Attributes.Get("cron"); ok {
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	309 if err = scheduler.BindAction(string(cfg.Kind), cron, id); err != nil {
1589 e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	310 return
e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	311 }
2051 7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	312 }
1589 e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	313
2051 7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	314 if err = tx.Commit(); err != nil {
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	315 scheduler.UnbindByID(id)
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	316 return
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	317 }
1589 e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	318
2051 7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	319 var result = struct {
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	320 ID int64 `json:"id"`
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	321 }{
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	322 ID: id,
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	323 }
1589 e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	324
2051 7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	325 jr = JSONResult{
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	326 Code: http.StatusCreated,
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	327 Result: &result,
7d627258e045 Imports: Re-enabled /imports/config POST. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2050 diff changeset	328 }
1589 e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	329 return
e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	330 }
e0bd82f6ee14 Added PUT /api/imports/scheduler to add a import configuration. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1583 diff changeset	331
1627 b10aa02d7819 Refactored: Moved REST /api/imports/scheduler to /api/imports/config Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1592 diff changeset	332 func listImportConfigs(
1582 dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	333 _ interface{},
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	334 req *http.Request,
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	335 conn *sql.Conn,
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	336 ) (jr JSONResult, err error) {
1583 caedd9b176f2 Added GET to /api/imports/scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1582 diff changeset	337
2049 d1a680be7ae4 Imports. Re-enabled /imports/config GET. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2048 diff changeset	338 ctx := req.Context()
d1a680be7ae4 Imports. Re-enabled /imports/config GET. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2048 diff changeset	339 configs := []*imports.ImportConfigOut{}
2042 d29ac997eb34 This breaks this branch!!!! Starting to remove the old persistent layer for configured imports. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2016 diff changeset	340
2049 d1a680be7ae4 Imports. Re-enabled /imports/config GET. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2048 diff changeset	341 if err = imports.ListAllPersistentConfigurationsContext(
d1a680be7ae4 Imports. Re-enabled /imports/config GET. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2048 diff changeset	342 ctx, conn,
d1a680be7ae4 Imports. Re-enabled /imports/config GET. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2048 diff changeset	343 func(config *imports.ImportConfigOut) error {
d1a680be7ae4 Imports. Re-enabled /imports/config GET. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2048 diff changeset	344 configs = append(configs, config)
d1a680be7ae4 Imports. Re-enabled /imports/config GET. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2048 diff changeset	345 return nil
d1a680be7ae4 Imports. Re-enabled /imports/config GET. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2048 diff changeset	346 },
d1a680be7ae4 Imports. Re-enabled /imports/config GET. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2048 diff changeset	347 ); err != nil {
d1a680be7ae4 Imports. Re-enabled /imports/config GET. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2048 diff changeset	348 return
d1a680be7ae4 Imports. Re-enabled /imports/config GET. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2048 diff changeset	349 }
d1a680be7ae4 Imports. Re-enabled /imports/config GET. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2048 diff changeset	350 jr = JSONResult{Result: configs}
1582 dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	351 return
dc727824183a Started with REST API for scheduler. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: diff changeset	352 }

Mercurial > gemma

annotate pkg/controllers/importconfig.go @ 3678:8f58851927c0