diff pkg/controllers/ubnimports.go @ 2194:4d6979dedb11

Imports: Deduplicted file upload code.
author Sascha L. Teichmann <sascha.teichmann@intevation.de>
date Tue, 12 Feb 2019 11:09:55 +0100
parents 4b9496752d89
children
line wrap: on
line diff
--- a/pkg/controllers/ubnimports.go	Tue Feb 12 10:50:03 2019 +0100
+++ b/pkg/controllers/ubnimports.go	Tue Feb 12 11:09:55 2019 +0100
@@ -14,19 +14,14 @@
 package controllers
 
 import (
-	"bufio"
-	"io"
-	"io/ioutil"
 	"log"
 	"net/http"
-	"os"
-	"path/filepath"
 	"time"
 
 	"gemma.intevation.de/gemma/pkg/auth"
 	"gemma.intevation.de/gemma/pkg/common"
-	"gemma.intevation.de/gemma/pkg/config"
 	"gemma.intevation.de/gemma/pkg/imports"
+	"gemma.intevation.de/gemma/pkg/misc"
 )
 
 const (
@@ -34,46 +29,13 @@
 	uploadBottleneckName      = "ubn"
 )
 
-func storeUploadedBottleneck(req *http.Request) (string, error) {
-
-	// Check for direct upload.
-	f, _, err := req.FormFile(uploadBottleneckName)
-	if err != nil {
-		return "", err
-	}
-	defer f.Close()
-
-	dir, err := ioutil.TempDir(config.TmpDir(), uploadBottleneckName)
-	if err != nil {
-		return "", err
-	}
-
-	o, err := os.Create(filepath.Join(dir, "data.xml"))
-	if err != nil {
-		os.RemoveAll(dir)
-		return "", err
-	}
-
-	out := bufio.NewWriter(o)
-
-	if _, err = io.Copy(out, io.LimitReader(f, maxUploadedBottleneckSize)); err != nil {
-		o.Close()
-		os.RemoveAll(dir)
-		return "", err
-	}
-
-	if err = out.Flush(); err != nil {
-		o.Close()
-		os.RemoveAll(dir)
-		return "", err
-	}
-
-	return dir, nil
-}
-
 func importUploadedBottleneck(rw http.ResponseWriter, req *http.Request) {
 
-	dir, err := storeUploadedBottleneck(req)
+	dir, err := misc.StoreUploadedFile(
+		req,
+		uploadBottleneckName,
+		"data.xml",
+		maxUploadedBottleneckSize)
 	if err != nil {
 		log.Printf("error: %v\n", err)
 		http.Error(rw, "error: "+err.Error(), http.StatusInternalServerError)