# HG changeset patch # User Sascha L. Teichmann # Date 1547649323 -3600 # Node ID 1ecfcf46e4da736b611429516b92c28be1e29ca3 # Parent 27c4effba5b190865aa4310fa64f57568187e143 Waterway area/axis: Be more informative if features are bad. diff -r 27c4effba5b1 -r 1ecfcf46e4da pkg/imports/wa.go --- a/pkg/imports/wa.go Wed Jan 16 15:29:41 2019 +0100 +++ b/pkg/imports/wa.go Wed Jan 16 15:35:23 2019 +0100 @@ -255,12 +255,6 @@ return nil, err } - if features == 0 { - err := errors.New("No features found") - feedback.Error("%v", err) - return nil, err - } - if badProperties > 0 { feedback.Warn("Bad properties: %d", badProperties) } @@ -273,6 +267,12 @@ feedback.Warn("Unsupported types found: %s", unsupported) } + if features == 0 { + err := errors.New("No features found") + feedback.Error("%v", err) + return nil, err + } + if err = tx.Commit(); err == nil { feedback.Info("Storing %d features took %s", features, time.Since(start)) diff -r 27c4effba5b1 -r 1ecfcf46e4da pkg/imports/wx.go --- a/pkg/imports/wx.go Wed Jan 16 15:29:41 2019 +0100 +++ b/pkg/imports/wx.go Wed Jan 16 15:35:23 2019 +0100 @@ -264,12 +264,6 @@ return nil, err } - if features == 0 { - err := errors.New("No features found") - feedback.Error("%v", err) - return nil, err - } - if badProperties > 0 { feedback.Warn("Bad properties: %d", badProperties) } @@ -282,6 +276,12 @@ feedback.Warn("Unsupported types found: %s", unsupported) } + if features == 0 { + err := errors.New("No features found") + feedback.Error("%v", err) + return nil, err + } + if err = tx.Commit(); err == nil { feedback.Info("Storing %d features took %s", features, time.Since(start))