# HG changeset patch # User Tom Gottfried # Date 1565016348 -7200 # Node ID d3fb2f37380b24b5aa0fe7b68c6cd84109b10886 # Parent 5a650cde057452d88ad218ad3dd130506930c0e7 Schema qualify tables in function body This prevents errors or unexpected results in situations where the search_path does otherwise not allow to find the expected table. diff -r 5a650cde0574 -r d3fb2f37380b schema/gemma.sql --- a/schema/gemma.sql Mon Aug 05 16:43:31 2019 +0200 +++ b/schema/gemma.sql Mon Aug 05 16:45:48 2019 +0200 @@ -228,7 +228,7 @@ CREATE OR REPLACE FUNCTION get_schema_version() RETURNS int LANGUAGE sql AS $$ - SELECT max(version) FROM gemma_schema_version; + SELECT max(version) FROM public.gemma_schema_version; $$; diff -r 5a650cde0574 -r d3fb2f37380b schema/isrs.sql --- a/schema/isrs.sql Mon Aug 05 16:43:31 2019 +0200 +++ b/schema/isrs.sql Mon Aug 05 16:45:48 2019 +0200 @@ -23,7 +23,7 @@ CREATE OR REPLACE FUNCTION is_country(code char) RETURNS boolean AS $$ - SELECT EXISTS(SELECT 1 FROM countries WHERE country_code = code) + SELECT EXISTS(SELECT 1 FROM public.countries WHERE country_code = code) $$ LANGUAGE sql STABLE PARALLEL SAFE; diff -r 5a650cde0574 -r d3fb2f37380b schema/updates/1106/01.schemaqualify_tables.sql --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/schema/updates/1106/01.schemaqualify_tables.sql Mon Aug 05 16:45:48 2019 +0200 @@ -0,0 +1,12 @@ +CREATE OR REPLACE FUNCTION get_schema_version() RETURNS int + LANGUAGE sql + AS $$ + SELECT max(version) FROM public.gemma_schema_version; +$$; + +CREATE OR REPLACE FUNCTION is_country(code char) RETURNS boolean +AS $$ + SELECT EXISTS(SELECT 1 FROM public.countries WHERE country_code = code) +$$ + LANGUAGE sql + STABLE PARALLEL SAFE;