Mercurial > gemma
changeset 3963:feb53713bc2f diagram-cleanup
client: moved duplicated code to mixins and unified code patterns in diagram components [WIP]
author | Markus Kottlaender <markus@intevation.de> |
---|---|
date | Fri, 12 Jul 2019 15:14:16 +0200 |
parents | 0ed8af02d5a9 |
children | afc7bca44df4 |
files | client/src/components/fairway/AvailableFairwayDepth.vue client/src/components/fairway/AvailableFairwayDepthLNWL.vue client/src/components/fairway/Fairwayprofile.vue client/src/components/gauge/HydrologicalConditions.vue client/src/components/gauge/Waterlevel.vue client/src/lib/mixins.js |
diffstat | 6 files changed, 197 insertions(+), 553 deletions(-) [+] |
line wrap: on
line diff
--- a/client/src/components/fairway/AvailableFairwayDepth.vue Fri Jul 12 11:58:20 2019 +0200 +++ b/client/src/components/fairway/AvailableFairwayDepth.vue Fri Jul 12 15:14:16 2019 +0200 @@ -1,7 +1,6 @@ <template> <div class="d-flex flex-column flex-fill"> <UIBoxHeader icon="chart-area" :title="title" :closeCallback="close" /> - <UISpinnerOverlay v-if="loading" /> <div class="d-flex flex-fill"> <DiagramLegend> <div v-for="(entry, index) in legend" :key="index" class="legend"> @@ -44,16 +43,17 @@ </div> </DiagramLegend> <div - ref="diagramContainer" + class="d-flex flex-fill justify-content-center align-items-center" :id="containerId" - class="diagram-container flex-fill" - ></div> + > + <div v-if="!fwData.length"> + <translate>No data available.</translate> + </div> + </div> </div> </div> </template> -<style></style> - <script> /* This is Free Software under GNU Affero General Public License v >= 3.0 * without warranty, see README.md and license for details. @@ -71,17 +71,19 @@ * * Fadi Abbud <fadi.abbud@intevation.de> */ import * as d3 from "d3"; -import app from "@/main"; -import debounce from "debounce"; import { mapState } from "vuex"; -import filters from "@/lib/filters.js"; import { diagram, pdfgen, templateLoader } from "@/lib/mixins"; -import { HTTP } from "@/lib/http"; -import { displayError } from "@/lib/errors"; import { FREQUENCIES } from "@/store/fairwayavailability"; -import { defaultDiagramTemplate } from "@/lib/DefaultDiagramTemplate"; +import filters from "@/lib/filters.js"; +// hoursInDays is a const instead of component method because it's used where +// the component context is not available const hoursInDays = x => x / 24; +const COLORS = { + LDC: "#cdcdcd", + HIGHEST: "#3675ff", + REST: ["#782121", "#ff6c6c", "#ffaaaa"] +}; export default { mixins: [diagram, pdfgen, templateLoader], @@ -91,66 +93,11 @@ data() { return { containerId: "availablefairwaydepth-diagram-container", - resizeListenerFunction: null, - loading: false, scalePaddingLeft: 60, scalePaddingRight: 0, - paddingTop: 25, - pdf: { - doc: null, - width: null, - height: null - }, - form: { - template: null - }, - templateData: null, - templates: [], - defaultTemplate: defaultDiagramTemplate + paddingTop: 25 }; }, - created() { - this.resizeListenerFunction = debounce(this.drawDiagram, 100); - window.addEventListener("resize", this.resizeListenerFunction); - }, - destroyed() { - window.removeEventListener("resize", this.resizeListenerFunction); - }, - mounted() { - // Nasty but necessary if we don't want to use the updated hook to re-draw - // the diagram because this would re-draw it also for irrelevant reasons. - // In this case we need to wait for the child component (DiagramLegend) to - // render. According to the docs (https://vuejs.org/v2/api/#mounted) this - // should be possible with $nextTick() but it doesn't work because it does - // not guarantee that the DOM is not only updated but also re-painted on the - // screen. - setTimeout(this.drawDiagram, 150); - - this.templates[0] = this.defaultTemplate; - this.form.template = this.templates[0]; - this.templateData = this.form.template; - HTTP.get("/templates/diagram", { - headers: { - "X-Gemma-Auth": localStorage.getItem("token"), - "Content-type": "text/xml; charset=UTF-8" - } - }) - .then(response => { - if (response.data.length) { - this.templates = response.data; - this.form.template = this.templates[0]; - this.templates[this.templates.length] = this.defaultTemplate; - this.applyChange(); - } - }) - .catch(e => { - const { status, data } = e.response; - displayError({ - title: this.$gettext("Backend Error"), - message: `${status}: ${data.message || data}` - }); - }); - }, computed: { ...mapState("fairwayavailability", [ "selectedFairwayAvailabilityFeature", @@ -216,32 +163,6 @@ } }, methods: { - applyChange() { - if (this.form.template.hasOwnProperty("properties")) { - this.templateData = this.defaultTemplate; - return; - } - if (this.form.template) { - this.loadTemplates("/templates/diagram/" + this.form.template.name) - .then(response => { - this.prepareImages(response.data.template_data.elements).then( - values => { - values.forEach(v => { - response.data.template_data.elements[v.index].url = v.url; - }); - this.templateData = response.data.template_data; - } - ); - }) - .catch(e => { - const { status, data } = e.response; - displayError({ - title: this.$gettext("Backend Error"), - message: `${status}: ${data.message || data}` - }); - }); - } - }, downloadPDF() { let title = `Available Fairway Depth: ${this.featureName}`; this.generatePDF({ @@ -266,60 +187,54 @@ } this.pdf.doc.setTextColor(color); - this.pdf.doc.setDrawColor(this.$options.COLORS.LDC); - this.pdf.doc.setFillColor(this.$options.COLORS.LDC); + this.pdf.doc.setDrawColor(COLORS.LDC); + this.pdf.doc.setFillColor(COLORS.LDC); this.pdf.doc.roundedRect(x, y, 10, 4, 1.5, 1.5, "FD"); this.pdf.doc.text(this.legend[0], x + 12, y + 3); - this.pdf.doc.setDrawColor(this.$options.COLORS.REST[0]); - this.pdf.doc.setFillColor(this.$options.COLORS.REST[0]); + this.pdf.doc.setDrawColor(COLORS.REST[0]); + this.pdf.doc.setFillColor(COLORS.REST[0]); this.pdf.doc.roundedRect(x, y + 5, 10, 4, 1.5, 1.5, "FD"); this.pdf.doc.text(this.legend[1], x + 12, y + 8); - this.pdf.doc.setDrawColor(this.$options.COLORS.REST[1]); - this.pdf.doc.setFillColor(this.$options.COLORS.REST[1]); + this.pdf.doc.setDrawColor(COLORS.REST[1]); + this.pdf.doc.setFillColor(COLORS.REST[1]); this.pdf.doc.roundedRect(x, y + 10, 10, 4, 1.5, 1.5, "FD"); this.pdf.doc.text(this.legend[2], x + 12, y + 13); - this.pdf.doc.setDrawColor(this.$options.COLORS.HIGHEST); - this.pdf.doc.setFillColor(this.$options.COLORS.HIGHEST); + this.pdf.doc.setDrawColor(COLORS.HIGHEST); + this.pdf.doc.setFillColor(COLORS.HIGHEST); this.pdf.doc.roundedRect(x, y + 15, 10, 4, 1.5, 1.5, "FD"); this.pdf.doc.text(this.legend[3], x + 12, y + 18); }, legendStyle(index) { return [ - `background-color: ${this.$options.COLORS.LDC};`, - `background-color: ${this.$options.COLORS.HIGHEST};`, - `background-color: ${this.$options.COLORS.REST[1]};`, - `background-color: ${this.$options.COLORS.REST[0]};` + `background-color: ${COLORS.LDC};`, + `background-color: ${COLORS.HIGHEST};`, + `background-color: ${COLORS.REST[1]};`, + `background-color: ${COLORS.REST[0]};` ][index]; }, close() { this.$store.commit("application/paneSetup", "DEFAULT"); }, - getPrintLayout(svgHeight) { + getPrintLayout() { return { - main: { top: 0, right: 20, bottom: 50, left: 20 }, - nav: { - top: svgHeight - 65, - right: 20, - bottom: 30, - left: 80 - } + main: { top: 0, right: 20, bottom: 50, left: 20 } }; }, drawDiagram() { const elem = document.querySelector("#" + this.containerId); const svgWidth = elem != null ? elem.clientWidth : 0; const svgHeight = elem != null ? elem.clientHeight : 0; - const layout = this.getPrintLayout(svgHeight); + const layout = this.getPrintLayout(); const dimensions = this.getDimensions({ svgHeight, svgWidth, ...layout }); - d3.select(".diagram-container svg").remove(); - this.renderTo({ element: ".diagram-container", dimensions }); + d3.select("#" + this.containerId + " svg").remove(); + this.renderTo({ element: "#" + this.containerId, dimensions }); }, renderTo({ element, dimensions }) { const diagram = d3 @@ -440,7 +355,7 @@ .attr("x", ldcOffset + spaceBetween / 2) .attr("width", widthPerItem - ldcOffset - spaceBetween) .attr("fill", (d, i) => { - return this.$options.COLORS.REST[i]; + return COLORS.REST[i]; }); }, fnheight({ name, yScale }) { @@ -479,7 +394,7 @@ "transform", d => `translate(0 ${this.paddingTop + -1 * height(d)})` ) - .attr("fill", this.$options.COLORS.LDC) + .attr("fill", COLORS.LDC) .attr("id", "ldc"); }, drawHighestLevel({ @@ -523,7 +438,7 @@ "transform", d => `translate(0 ${this.paddingTop + -1 * height(d)})` ) - .attr("fill", this.$options.COLORS.HIGHEST); + .attr("fill", COLORS.HIGHEST); }, drawLabelPerBar({ everyBar, dimensions, widthPerItem }) { everyBar @@ -537,7 +452,7 @@ drawScaleLabel({ diagram, dimensions }) { diagram .append("text") - .text(this.$options.LEGEND) + .text(this.$gettext("Sum of days")) .attr("text-anchor", "middle") .attr("x", 0) .attr("y", 0) @@ -615,12 +530,6 @@ fwData() { this.drawDiagram(); } - }, - LEGEND: app.$gettext("Sum of days"), - COLORS: { - LDC: "#cdcdcd", - HIGHEST: "#3675ff", - REST: ["#782121", "#ff6c6c", "#ffaaaa"] } }; </script>
--- a/client/src/components/fairway/AvailableFairwayDepthLNWL.vue Fri Jul 12 11:58:20 2019 +0200 +++ b/client/src/components/fairway/AvailableFairwayDepthLNWL.vue Fri Jul 12 15:14:16 2019 +0200 @@ -1,7 +1,6 @@ <template> <div class="d-flex flex-column flex-fill"> <UIBoxHeader icon="chart-area" :title="title" :closeCallback="close" /> - <UISpinnerOverlay v-if="loading" /> <div class="d-flex flex-fill"> <DiagramLegend> <div v-for="(entry, index) in legendLNWL" :key="index" class="legend"> @@ -44,16 +43,17 @@ </div> </DiagramLegend> <div - ref="diagramContainer" + class="d-flex flex-fill justify-content-center align-items-center" :id="containerId" - class="diagram-container flex-fill" - ></div> + > + <div v-if="!fwLNWLData.length"> + <translate>No data available.</translate> + </div> + </div> </div> </div> </template> -<style></style> - <script> /* This is Free Software under GNU Affero General Public License v >= 3.0 * without warranty, see README.md and license for details. @@ -71,14 +71,9 @@ * * Fadi Abbud <fadi.abbud@intevation.de> */ import * as d3 from "d3"; -import app from "@/main"; -import debounce from "debounce"; import { mapState } from "vuex"; +import { diagram, pdfgen, templateLoader } from "@/lib/mixins"; import filters from "@/lib/filters.js"; -import { diagram, pdfgen, templateLoader } from "@/lib/mixins"; -import { HTTP } from "@/lib/http"; -import { displayError } from "@/lib/errors"; -import { defaultDiagramTemplate } from "@/lib/DefaultDiagramTemplate"; export default { mixins: [diagram, pdfgen, templateLoader], @@ -88,66 +83,15 @@ data() { return { containerId: "availablefairwaydepthlnwl-diagram-container", - resizeListenerFunction: null, - loading: false, scalePaddingLeft: 60, scalePaddingRight: 0, paddingTop: 25, - pdf: { - doc: null, - width: null, - height: null - }, - form: { - template: null - }, - templateData: null, - templates: [], - defaultTemplate: defaultDiagramTemplate + colors: { + afd: ["#3636ff", "#f49b7f", "#e15472"], + lnwl: "#97ddf3" + } }; }, - created() { - this.resizeListenerFunction = debounce(this.drawDiagram, 100); - window.addEventListener("resize", this.resizeListenerFunction); - }, - destroyed() { - window.removeEventListener("resize", this.resizeListenerFunction); - }, - mounted() { - // Nasty but necessary if we don't want to use the updated hook to re-draw - // the diagram because this would re-draw it also for irrelevant reasons. - // In this case we need to wait for the child component (DiagramLegend) to - // render. According to the docs (https://vuejs.org/v2/api/#mounted) this - // should be possible with $nextTick() but it doesn't work because it does - // not guarantee that the DOM is not only updated but also re-painted on the - // screen. - setTimeout(this.drawDiagram, 150); - - this.templates[0] = this.defaultTemplate; - this.form.template = this.templates[0]; - this.templateData = this.form.template; - HTTP.get("/templates/diagram", { - headers: { - "X-Gemma-Auth": localStorage.getItem("token"), - "Content-type": "text/xml; charset=UTF-8" - } - }) - .then(response => { - if (response.data.length) { - this.templates = response.data; - this.form.template = this.templates[0]; - this.templates[this.templates.length] = this.defaultTemplate; - this.applyChange(); - } - }) - .catch(e => { - const { status, data } = e.response; - displayError({ - title: this.$gettext("Backend Error"), - message: `${status}: ${data.message || data}` - }); - }); - }, computed: { ...mapState("fairwayavailability", [ "selectedFairwayAvailabilityFeature", @@ -207,39 +151,13 @@ methods: { legendStyle(index) { const style = { - 0: `background-color: ${this.$options.LWNLCOLORS.LDC};`, - 1: `background-color: ${this.$options.AFDCOLORS[2]};`, - 2: `background-color: ${this.$options.AFDCOLORS[1]};`, - 3: `background-color: ${this.$options.AFDCOLORS[0]};` + 0: `background-color: ${this.colors.lnwl};`, + 1: `background-color: ${this.colors.afd[2]};`, + 2: `background-color: ${this.colors.afd[1]};`, + 3: `background-color: ${this.colors.afd[0]};` }; return style[index]; }, - applyChange() { - if (this.form.template.hasOwnProperty("properties")) { - this.templateData = this.defaultTemplate; - return; - } - if (this.form.template) { - this.loadTemplates("/templates/diagram/" + this.form.template.name) - .then(response => { - this.prepareImages(response.data.template_data.elements).then( - values => { - values.forEach(v => { - response.data.template_data.elements[v.index].url = v.url; - }); - this.templateData = response.data.template_data; - } - ); - }) - .catch(e => { - const { status, data } = e.response; - displayError({ - title: this.$gettext("Backend Error"), - message: `${status}: ${data.message || data}` - }); - }); - } - }, downloadPDF() { let title = `Available Fairway Depth vs LNWL: ${this.featureName}`; this.generatePDF({ @@ -263,52 +181,46 @@ y = this.pdf.height - offset.y - this.getTextHeight(6); } this.pdf.doc.setTextColor(color); - this.pdf.doc.setDrawColor(this.$options.LWNLCOLORS.LDC); - this.pdf.doc.setFillColor(this.$options.LWNLCOLORS.LDC); + this.pdf.doc.setDrawColor(this.colors.lnwl); + this.pdf.doc.setFillColor(this.colors.lnwl); this.pdf.doc.roundedRect(x, y, 10, 4, 1.5, 1.5, "FD"); this.pdf.doc.text(this.legendLNWL[0], x + 12, y + 3); - this.pdf.doc.setDrawColor(this.$options.AFDCOLORS[2]); - this.pdf.doc.setFillColor(this.$options.AFDCOLORS[2]); + this.pdf.doc.setDrawColor(this.colors.afd[2]); + this.pdf.doc.setFillColor(this.colors.afd[2]); this.pdf.doc.roundedRect(x, y + 5, 10, 4, 1.5, 1.5, "FD"); this.pdf.doc.text(this.legendLNWL[1], x + 12, y + 8); - this.pdf.doc.setDrawColor(this.$options.AFDCOLORS[1]); - this.pdf.doc.setFillColor(this.$options.AFDCOLORS[1]); + this.pdf.doc.setDrawColor(this.colors.afd[1]); + this.pdf.doc.setFillColor(this.colors.afd[1]); this.pdf.doc.roundedRect(x, y + 10, 10, 4, 1.5, 1.5, "FD"); this.pdf.doc.text(this.legendLNWL[2], x + 12, y + 13); - this.pdf.doc.setDrawColor(this.$options.AFDCOLORS[0]); - this.pdf.doc.setFillColor(this.$options.AFDCOLORS[0]); + this.pdf.doc.setDrawColor(this.colors.afd[0]); + this.pdf.doc.setFillColor(this.colors.afd[0]); this.pdf.doc.roundedRect(x, y + 15, 10, 4, 1.5, 1.5, "FD"); this.pdf.doc.text(this.legendLNWL[3], x + 12, y + 18); }, close() { this.$store.commit("application/paneSetup", "DEFAULT"); }, - getPrintLayout(svgHeight) { + getPrintLayout() { return { - main: { top: 0, right: 20, bottom: 50, left: 20 }, - nav: { - top: svgHeight - 65, - right: 20, - bottom: 30, - left: 80 - } + main: { top: 0, right: 20, bottom: 50, left: 20 } }; }, drawDiagram() { const elem = document.querySelector("#" + this.containerId); const svgWidth = elem != null ? elem.clientWidth : 0; const svgHeight = elem != null ? elem.clientHeight : 0; - const layout = this.getPrintLayout(svgHeight); + const layout = this.getPrintLayout(); const dimensions = this.getDimensions({ svgHeight, svgWidth, ...layout }); - d3.select(".diagram-container svg").remove(); - this.renderTo({ element: ".diagram-container", dimensions }); + d3.select("#" + this.containerId + " svg").remove(); + this.renderTo({ element: "#" + this.containerId, dimensions }); }, drawTooltip(diagram) { diagram @@ -442,7 +354,7 @@ .attr("transform", `translate(0 ${this.paddingTop})`) .attr("width", afdWidth) .attr("fill", (d, i) => { - return this.$options.AFDCOLORS[i]; + return this.colors.afd[i]; }); }, drawLNWL(data, i, diagram, spaceBetween, widthPerItem, ldcWidth, yScale) { @@ -486,13 +398,13 @@ .attr("transform", `translate(0 ${this.paddingTop})`) .attr("width", ldcWidth) .attr("fill", () => { - return this.$options.LWNLCOLORS.LDC; + return this.colors.lnwl; }); }, drawScaleLabel({ diagram, dimensions }) { diagram .append("text") - .text(this.$options.LEGEND) + .text(this.$gettext("Percent")) .attr("text-anchor", "middle") .attr("x", 0) .attr("y", 0) @@ -571,12 +483,6 @@ fwLNWLData() { this.drawDiagram(); } - }, - LEGEND: app.$gettext("Percent"), - AFDCOLORS: ["#3636ff", "#f49b7f", "#e15472"], - LWNLCOLORS: { - LDC: "#97ddf3", - HDC: "#43FFE1" } }; </script>
--- a/client/src/components/fairway/Fairwayprofile.vue Fri Jul 12 11:58:20 2019 +0200 +++ b/client/src/components/fairway/Fairwayprofile.vue Fri Jul 12 15:14:16 2019 +0200 @@ -93,12 +93,11 @@ </div> </DiagramLegend> <div - ref="pdfContainer" - id="pdfContainer" - class="d-flex flex-fill justify-content-center align-items-center diagram-container position-relative" + class="d-flex flex-fill justify-content-center align-items-center position-relative" + :id="containerId" > <div class="direction-indicator"></div> - <div v-if="!fairwayData"> + <div v-if="!fairwayData.length"> <translate>No data available.</translate> </div> </div> @@ -148,37 +147,21 @@ */ import * as d3 from "d3"; import { mapState, mapGetters } from "vuex"; -import debounce from "debounce"; import { diagram, pdfgen, templateLoader } from "@/lib/mixins"; -import { HTTP } from "@/lib/http"; -import { displayError } from "@/lib/errors"; -import { defaultDiagramTemplate } from "@/lib/DefaultDiagramTemplate"; const GROUND_COLOR = "#4A2F06"; const WATER_COLOR = "#005DFF"; export default { mixins: [diagram, pdfgen, templateLoader], - name: "fairwayprofile", components: { DiagramLegend: () => import("@/components/DiagramLegend") }, data() { return { - resizeListenerFunction: null, + containerId: "fairwayprofile-diagram-container", width: null, - height: null, - form: { - template: null - }, - templates: [], - defaultTemplate: defaultDiagramTemplate, - pdf: { - doc: null, - width: 32, - height: 297 - }, - templateData: null + height: null }; }, computed: { @@ -293,32 +276,6 @@ return { fillColor, fillOpacity, strokeColor, strokeOpacity, strokeDash }; }, - applyChange() { - if (this.form.template.hasOwnProperty("properties")) { - this.templateData = this.defaultTemplate; - return; - } - if (this.form.template) { - this.loadTemplates("/templates/diagram/" + this.form.template.name) - .then(response => { - this.prepareImages(response.data.template_data.elements).then( - values => { - values.forEach(v => { - response.data.template_data.elements[v.index].url = v.url; - }); - this.templateData = response.data.template_data; - } - ); - }) - .catch(e => { - const { status, data } = e.response; - displayError({ - title: this.$gettext("Backend Error"), - message: `${status}: ${data.message || data}` - }); - }); - } - }, downloadPDF() { let fairwayInfo = this.selectedBottleneck + " (" + this.selectedSurvey.date_info + ")"; @@ -383,21 +340,16 @@ }, getPrintLayout() { return { - main: { - top: 20, - right: 80, - bottom: 60, - left: 80 - } + main: { top: 20, right: 80, bottom: 60, left: 80 } }; }, drawDiagram() { - d3.select(".diagram-container svg").remove(); + d3.select("#" + this.containerId + " svg").remove(); this.scaleFairwayProfile(); if (!this.height || !this.width) return; // do not try to render when height and width are unknown const layout = this.getPrintLayout(this.height); this.renderTo({ - element: ".diagram-container", + element: "#" + this.containerId, dimensions: this.getDimensions({ svgWidth: this.width, svgHeight: this.height, @@ -674,60 +626,15 @@ } }, scaleFairwayProfile() { - if (!document.querySelector(".diagram-container")) return; - const clientHeight = document.querySelector(".diagram-container") + if (!document.querySelector("#" + this.containerId)) return; + const clientHeight = document.querySelector("#" + this.containerId) .clientHeight; - const clientWidth = document.querySelector(".diagram-container") + const clientWidth = document.querySelector("#" + this.containerId) .clientWidth; if (!clientHeight || !clientWidth) return; this.height = clientHeight; this.width = clientWidth; } - }, - created() { - this.resizeListenerFunction = debounce(this.drawDiagram, 100); - window.addEventListener("resize", this.resizeListenerFunction); - }, - mounted() { - // Nasty but necessary if we don't want to use the updated hook to re-draw - // the diagram because this would re-draw it also for irrelevant reasons. - // In this case we need to wait for the child component (DiagramLegend) to - // render. According to the docs (https://vuejs.org/v2/api/#mounted) this - // should be possible with $nextTick() but it doesn't work because it does - // not guarantee that the DOM is not only updated but also re-painted on the - // screen. - setTimeout(this.drawDiagram, 150); - - this.templates[0] = this.defaultTemplate; - this.form.template = this.templates[0]; - this.templateData = this.form.template; - HTTP.get("/templates/diagram", { - headers: { - "X-Gemma-Auth": localStorage.getItem("token"), - "Content-type": "text/xml; charset=UTF-8" - } - }) - .then(response => { - if (response.data.length) { - this.templates = response.data; - this.form.template = this.templates[0]; - this.templates[this.templates.length] = this.defaultTemplate; - this.applyChange(); - } - }) - .catch(e => { - const { status, data } = e.response; - displayError({ - title: this.$gettext("Backend Error"), - message: `${status}: ${data.message || data}` - }); - }); - }, - updated() { - this.drawDiagram(); - }, - destroyed() { - window.removeEventListener("resize", this.resizeListenerFunction); } }; </script>
--- a/client/src/components/gauge/HydrologicalConditions.vue Fri Jul 12 11:58:20 2019 +0200 +++ b/client/src/components/gauge/HydrologicalConditions.vue Fri Jul 12 15:14:16 2019 +0200 @@ -1,13 +1,8 @@ <template> <div class="d-flex flex-column flex-fill"> - <UIBoxHeader - icon="ruler-vertical" - :title="title" - :closeCallback="close" - class="rounded-0" - /> + <UIBoxHeader icon="ruler-vertical" :title="title" :closeCallback="close" /> <div class="d-flex flex-fill"> - <DiagramLegend id="diagramlegendId"> + <DiagramLegend> <div class="legend"> <span style="background-color: red; width: 20px; height: 20px;" @@ -102,12 +97,8 @@ import { mapState, mapGetters } from "vuex"; import * as d3 from "d3"; -import debounce from "debounce"; import { startOfYear, endOfYear } from "date-fns"; import { diagram, pdfgen, templateLoader } from "@/lib/mixins"; -import { HTTP } from "@/lib/http"; -import { displayError } from "@/lib/errors"; -import { defaultDiagramTemplate } from "@/lib/DefaultDiagramTemplate"; export default { mixins: [diagram, pdfgen, templateLoader], @@ -116,20 +107,7 @@ }, data() { return { - containerId: "hydrologicalconditions-diagram-container", - resizeListenerFunction: null, - templateData: null, - form: { - template: null, - form: null - }, - templates: [], - defaultTemplate: defaultDiagramTemplate, - pdf: { - doc: null, - width: 420, - height: 297 - } + containerId: "hydrologicalconditions-diagram-container" }; }, computed: { @@ -213,32 +191,6 @@ " Hydrological-condition Diagram.pdf" ); }, - applyChange() { - if (this.form.template.hasOwnProperty("properties")) { - this.templateData = this.defaultTemplate; - return; - } - if (this.form.template) { - this.loadTemplates("/templates/diagram/" + this.form.template.name) - .then(response => { - this.prepareImages(response.data.template_data.elements).then( - values => { - values.forEach(v => { - response.data.template_data.elements[v.index].url = v.url; - }); - this.templateData = response.data.template_data; - } - ); - }) - .catch(e => { - const { status, data } = e.response; - displayError({ - title: this.$gettext("Backend Error"), - message: `${status}: ${data.message || data}` - }); - }); - } - }, // Diagram legend addDiagramLegend(position, offset, color) { let x = offset.x, @@ -969,48 +921,6 @@ .attr("height", textBBox.height + tooltipPadding * 2); }); } - }, - created() { - this.resizeListenerFunction = debounce(this.drawDiagram, 100); - window.addEventListener("resize", this.resizeListenerFunction); - }, - mounted() { - // Nasty but necessary if we don't want to use the updated hook to re-draw - // the diagram because this would re-draw it also for irrelevant reasons. - // In this case we need to wait for the child component (DiagramLegend) to - // render. According to the docs (https://vuejs.org/v2/api/#mounted) this - // should be possible with $nextTick() but it doesn't work because it does - // not guarantee that the DOM is not only updated but also re-painted on the - // screen. - setTimeout(this.drawDiagram, 150); - - this.templates[0] = this.defaultTemplate; - this.form.template = this.templates[0]; - this.templateData = this.form.template; - HTTP.get("/templates/diagram", { - headers: { - "X-Gemma-Auth": localStorage.getItem("token"), - "Content-type": "text/xml; charset=UTF-8" - } - }) - .then(response => { - if (response.data.length) { - this.templates = response.data; - this.form.template = this.templates[0]; - this.templates[this.templates.length] = this.defaultTemplate; - this.applyChange(); - } - }) - .catch(e => { - const { status, data } = e.response; - displayError({ - title: this.$gettext("Backend Error"), - message: `${status}: ${data.message || data}` - }); - }); - }, - destroyed() { - window.removeEventListener("resize", this.resizeListenerFunction); } }; </script>
--- a/client/src/components/gauge/Waterlevel.vue Fri Jul 12 11:58:20 2019 +0200 +++ b/client/src/components/gauge/Waterlevel.vue Fri Jul 12 15:14:16 2019 +0200 @@ -1,13 +1,8 @@ <template> <div class="d-flex flex-column flex-fill"> - <UIBoxHeader - icon="ruler-vertical" - :title="title" - :closeCallback="close" - class="rounded-0" - /> + <UIBoxHeader icon="ruler-vertical" :title="title" :closeCallback="close" /> <div class="d-flex flex-fill"> - <DiagramLegend id="diagramlegendId"> + <DiagramLegend> <div class="legend"> <span style="background-color: steelblue; width: 20px; height: 20px;" @@ -99,17 +94,12 @@ * * Markus Kottländer <markus.kottlaender@intevation.de> * * Fadi Abbud <fadi.abbud@intevation.de> */ - import { mapState, mapGetters } from "vuex"; import * as d3Base from "d3"; import { lineChunked } from "d3-line-chunked"; import { endOfDay } from "date-fns"; -import debounce from "debounce"; import { saveAs } from "file-saver"; import { diagram, pdfgen, templateLoader } from "@/lib/mixins"; -import { HTTP } from "@/lib/http"; -import { displayError } from "@/lib/errors"; -import { defaultDiagramTemplate } from "@/lib/DefaultDiagramTemplate"; // we should load only d3 modules we need but for now we'll go with the lazy way // https://www.giacomodebidda.com/how-to-import-d3-plugins-with-webpack/ // d3-line-chunked plugin: https://github.com/pbeshai/d3-line-chunked @@ -122,19 +112,7 @@ }, data() { return { - containerId: "waterlevel-diagram-container", - resizeListenerFunction: null, - form: { - template: null - }, - templates: [], - defaultTemplate: defaultDiagramTemplate, - pdf: { - doc: null, - width: 420, - height: 297 - }, - templateData: null + containerId: "waterlevel-diagram-container" }; }, computed: { @@ -219,32 +197,6 @@ this.selectedGauge.properties.objname + " Waterlevel-Diagram.pdf" ); }, - applyChange() { - if (this.form.template.hasOwnProperty("properties")) { - this.templateData = this.defaultTemplate; - return; - } - if (this.form.template) { - this.loadTemplates("/templates/diagram/" + this.form.template.name) - .then(response => { - this.prepareImages(response.data.template_data.elements).then( - values => { - values.forEach(v => { - response.data.template_data.elements[v.index].url = v.url; - }); - this.templateData = response.data.template_data; - } - ); - }) - .catch(e => { - const { status, data } = e.response; - displayError({ - title: this.$gettext("Backend Error"), - message: `${status}: ${data.message || data}` - }); - }); - } - }, // Diagram legend addDiagramLegend(position, offset, color) { let x = offset.x; @@ -950,8 +902,8 @@ .append("rect") .attr("rx", "0.25em") .attr("ry", "0.25em") - .attr("width", "0px") - .attr("height", "0px"); + .attr("width", "0") + .attr("height", "0"); // create container for multiple text rows const tooltipText = tooltip.append("text").attr("text-anchor", "middle"); @@ -1089,48 +1041,6 @@ return difference === 900; }; } - }, - created() { - this.resizeListenerFunction = debounce(this.drawDiagram, 100); - window.addEventListener("resize", this.resizeListenerFunction); - }, - mounted() { - // Nasty but necessary if we don't want to use the updated hook to re-draw - // the diagram because this would re-draw it also for irrelevant reasons. - // In this case we need to wait for the child component (DiagramLegend) to - // render. According to the docs (https://vuejs.org/v2/api/#mounted) this - // should be possible with $nextTick() but it doesn't work because it does - // not guarantee that the DOM is not only updated but also re-painted on the - // screen. - setTimeout(this.drawDiagram, 150); - - this.templates[0] = this.defaultTemplate; - this.form.template = this.templates[0]; - this.templateData = this.form.template; - HTTP.get("/templates/diagram", { - headers: { - "X-Gemma-Auth": localStorage.getItem("token"), - "Content-type": "text/xml; charset=UTF-8" - } - }) - .then(response => { - if (response.data.length) { - this.templates = response.data; - this.form.template = this.templates[0]; - this.templates[this.templates.length] = this.defaultTemplate; - this.applyChange(); - } - }) - .catch(e => { - const { status, data } = e.response; - displayError({ - title: this.$gettext("Backend Error"), - message: `${status}: ${data.message || data}` - }); - }); - }, - destroyed() { - window.removeEventListener("resize", this.resizeListenerFunction); } }; </script>
--- a/client/src/lib/mixins.js Fri Jul 12 11:58:20 2019 +0200 +++ b/client/src/lib/mixins.js Fri Jul 12 15:14:16 2019 +0200 @@ -16,8 +16,11 @@ import jsPDF from "jspdf-yworks"; import svg2pdf from "svg2pdf.js"; import locale2 from "locale2"; +import debounce from "debounce"; import { mapState } from "vuex"; import { HTTP } from "@/lib/http"; +import { displayError } from "@/lib/errors"; +import { defaultDiagramTemplate } from "@/lib/DefaultDiagramTemplate"; export const sortTable = { data() { @@ -37,25 +40,55 @@ }; export const diagram = { + data() { + return { + resizeListenerFunction: null + }; + }, methods: { - getDimensions({ svgWidth, svgHeight, main, nav }) { - const mainMargin = main || { + getDimensions({ svgWidth, svgHeight, main, nav, DPI }) { + const mainMargin = { top: 20, right: 80, bottom: 60, - left: 80 + left: 80, + ...main }; - const navMargin = nav || { + const navMargin = { top: svgHeight - mainMargin.top - 65, right: 20, bottom: 30, - left: 80 + left: 80, + ...nav }; + if (DPI) { + ["top", "right", "bottom", "left"].forEach(x => { + mainMargin[x] = this.millimeter2pixels(mainMargin[x], DPI); + navMargin[x] = this.millimeter2pixels(navMargin[x], DPI); + }); + } const width = Number(svgWidth) - mainMargin.left - mainMargin.right; const mainHeight = Number(svgHeight) - mainMargin.top - mainMargin.bottom; const navHeight = Number(svgHeight) - navMargin.top - navMargin.bottom; return { width, mainHeight, navHeight, mainMargin, navMargin }; } + }, + created() { + this.resizeListenerFunction = debounce(this.drawDiagram, 100); + window.addEventListener("resize", this.resizeListenerFunction); + }, + mounted() { + // Nasty but necessary if we don't want to use the updated hook to re-draw + // the diagram because this would re-draw it also for irrelevant reasons. + // In this case we need to wait for the child component (DiagramLegend) to + // render. According to the docs (https://vuejs.org/v2/api/#mounted) this + // should be possible with $nextTick() but it doesn't work because it does + // not guarantee that the DOM is not only updated but also re-painted on the + // screen. + setTimeout(this.drawDiagram, 150); + }, + destroyed() { + window.removeEventListener("resize", this.resizeListenerFunction); } }; @@ -129,6 +162,21 @@ }; export const pdfgen = { + data() { + return { + pdf: { + doc: null, + width: null, + height: null + }, + templates: [], + defaultTemplate: defaultDiagramTemplate, + templateData: null, + form: { + template: null + } + }; + }, computed: { ...mapState("application", ["logoForPDF"]), ...mapState("user", ["user"]) @@ -137,8 +185,9 @@ addDiagram(position, offset, width, height) { let x = offset.x, y = offset.y; - const svgWidth = this.millimeter2pixels(width, 80); - const svgHeight = this.millimeter2pixels(height, 80); + const DPI = this.templateData.properties.resoltion || 80; + const svgWidth = this.millimeter2pixels(width, DPI); + const svgHeight = this.millimeter2pixels(height, DPI); // draw the diagram in a separated html element to get the full size const offScreen = document.querySelector("#offScreen"); offScreen.style.width = `${svgWidth}px`; @@ -149,7 +198,8 @@ dimensions: this.getDimensions({ svgWidth: svgWidth, svgHeight: svgHeight, - ...layout + ...layout, + DPI: DPI }) }); var svg = offScreen.querySelector("svg"); @@ -162,7 +212,7 @@ svg2pdf(svg, this.pdf.doc, { xOffset: x, yOffset: y, - scale: 0.354 + scale: this.pixel2millimeter(1, DPI) }); offScreen.removeChild(svg); }, @@ -468,6 +518,58 @@ color, text ); + }, + applyChange() { + if (this.form.template.hasOwnProperty("properties")) { + this.templateData = this.defaultTemplate; + return; + } + if (this.form.template) { + this.loadTemplates("/templates/diagram/" + this.form.template.name) + .then(response => { + this.prepareImages(response.data.template_data.elements).then( + values => { + values.forEach(v => { + response.data.template_data.elements[v.index].url = v.url; + }); + this.templateData = response.data.template_data; + } + ); + }) + .catch(e => { + const { status, data } = e.response; + displayError({ + title: this.$gettext("Backend Error"), + message: `${status}: ${data.message || data}` + }); + }); + } } + }, + mounted() { + this.templates[0] = this.defaultTemplate; + this.form.template = this.templates[0]; + this.templateData = this.form.template; + HTTP.get("/templates/diagram", { + headers: { + "X-Gemma-Auth": localStorage.getItem("token"), + "Content-type": "text/xml; charset=UTF-8" + } + }) + .then(response => { + if (response.data.length) { + this.templates = response.data; + this.form.template = this.templates[0]; + this.templates[this.templates.length] = this.defaultTemplate; + this.applyChange(); + } + }) + .catch(e => { + const { status, data } = e.response; + displayError({ + title: this.$gettext("Backend Error"), + message: `${status}: ${data.message || data}` + }); + }); } };