annotate .coveragerc @ 7277:0cf121eae2fe

tests: fix caching issue in test_ip_restriction_git Following test failure is observed in TestVCSOperations.test_ip_restriction_git: ―――――――――――――― TestVCSOperations.test_ip_restriction_git ―――――――――――――――――― kallithea/tests/other/test_vcs_operations.py:584: in test_ip_restriction_git assert re.search(r'\b403\b', stderr) E assert None E + where None = <function search at 0x7fb9772da578>('\\b403\\b', "Cloning into '/tmp/kallithea-test-SZhXDz/vcs_operations-krPNvZ'...\n") E + where <function search at 0x7fb9772da578> = re.search ------------------------- Captured stdout call ---------------------------- *** CMD git clone http://test_admin:test12@127.0.0.1:45291/vcs_test_git /tmp/kallithea-test-SZhXDz/vcs_operations-krPNvZ *** stderr: "Cloning into '/tmp/kallithea-test-SZhXDz/vcs_operations-krPNvZ'...\n" The test is setting up IP restrictions, verifying that access is no longer possible, then clears the restriction. There already were sleeps after clearing the restrictions, in order for the cache to expire and have the setting take effect. But there was no sleep on the enabling of the IP restriction, allowing situations where the code would still run without restriction, and thus allow the access, failing the test. The failure has only been observed on test_ip_restriction_git, but the change is also made for test_ip_restriction_hg. The existing sleeps after restriction clearing are moved up to the 'finally' clause to make it clear to which code they belong.
author Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
date Sun, 06 May 2018 21:30:09 +0200
parents 0acb46763886
children ddee465a345a
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
6535
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
1 [run]
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
2 omit =
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
3 # the bin scripts are not part of the Kallithea web app
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
4 kallithea/bin/*
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
5 # we ship with no active extensions
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
6 kallithea/config/rcextensions/*
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
7 # dbmigrate and paster_commands are not part of the Kallithea web app
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
8 kallithea/lib/dbmigrate/*
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
9 kallithea/lib/paster_commands/*
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
10 # the tests themselves should not be part of the coverage report
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
11 kallithea/tests/*
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
12 # the scm hooks are not run in the kallithea process
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
13 kallithea/config/post_receive_tmpl.py
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
14 kallithea/config/pre_receive_tmpl.py
6924
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
15
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
16 [paths]
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
17 source =
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
18 kallithea/
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
19 **/workspace/*/kallithea