Mercurial > kallithea
annotate tox.ini @ 7277:0cf121eae2fe
tests: fix caching issue in test_ip_restriction_git
Following test failure is observed in
TestVCSOperations.test_ip_restriction_git:
―――――――――――――― TestVCSOperations.test_ip_restriction_git ――――――――――――――――――
kallithea/tests/other/test_vcs_operations.py:584: in test_ip_restriction_git
assert re.search(r'\b403\b', stderr)
E assert None
E + where None = <function search at 0x7fb9772da578>('\\b403\\b', "Cloning into '/tmp/kallithea-test-SZhXDz/vcs_operations-krPNvZ'...\n")
E + where <function search at 0x7fb9772da578> = re.search
------------------------- Captured stdout call ----------------------------
*** CMD git clone http://test_admin:test12@127.0.0.1:45291/vcs_test_git /tmp/kallithea-test-SZhXDz/vcs_operations-krPNvZ ***
stderr: "Cloning into '/tmp/kallithea-test-SZhXDz/vcs_operations-krPNvZ'...\n"
The test is setting up IP restrictions, verifying that access is no longer
possible, then clears the restriction. There already were sleeps after
clearing the restrictions, in order for the cache to expire and have the
setting take effect.
But there was no sleep on the enabling of the IP restriction, allowing
situations where the code would still run without restriction, and thus
allow the access, failing the test.
The failure has only been observed on test_ip_restriction_git, but the
change is also made for test_ip_restriction_hg.
The existing sleeps after restriction clearing are moved up to the 'finally'
clause to make it clear to which code they belong.
author | Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> |
---|---|
date | Sun, 06 May 2018 21:30:09 +0200 |
parents | dd676fdeda0f |
children | ab30729c735c |
rev | line source |
---|---|
5015 | 1 [tox] |
5389
768989c595aa
tox.ini: declare 1.8 as minimum tox version
Mads Kiilerich <madski@unity3d.com>
parents:
5061
diff
changeset
|
2 minversion = 1.8 |
5699
6a83b399bb3c
pytest migration: remove nose from tox configuration
Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
parents:
5389
diff
changeset
|
3 envlist = py{26,27}-pytest |
5015 | 4 |
5 [testenv] | |
5017
9c5e6984bd0e
tox.ini: Set PYTHONHASHSEED = 0
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5016
diff
changeset
|
6 setenv = |
9c5e6984bd0e
tox.ini: Set PYTHONHASHSEED = 0
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5016
diff
changeset
|
7 PYTHONHASHSEED = 0 |
5016
46662961d58d
tox.ini: Add nose and pytest deps
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5015
diff
changeset
|
8 deps = |
6026
dd676fdeda0f
setup: move test dependencies to dev_requirements.txt to make them optional
Mads Kiilerich <madski@unity3d.com>
parents:
5995
diff
changeset
|
9 -r{toxinidir}/dev_requirements.txt |
dd676fdeda0f
setup: move test dependencies to dev_requirements.txt to make them optional
Mads Kiilerich <madski@unity3d.com>
parents:
5995
diff
changeset
|
10 py26-pytest: unittest2 |
5995
b2195895bbd7
tests: install pam and ldap modules when testing with tox
Mads Kiilerich <madski@unity3d.com>
parents:
5699
diff
changeset
|
11 python-ldap |
b2195895bbd7
tests: install pam and ldap modules when testing with tox
Mads Kiilerich <madski@unity3d.com>
parents:
5699
diff
changeset
|
12 python-pam |
5016
46662961d58d
tox.ini: Add nose and pytest deps
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5015
diff
changeset
|
13 commands = |
46662961d58d
tox.ini: Add nose and pytest deps
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5015
diff
changeset
|
14 pytest: py.test {posargs} |