annotate .coveragerc @ 8163:24e1099e4f29

py3: make get_current_authuser handle missing tg context consistently and explicitly tg context handling ends up using tg.support.registry.StackedObjectProxy._current_obj for attribute access ... which if no context has been pushed will end up in: raise TypeError( 'No object (name: %s) has been registered for this ' 'thread' % self.____name__) utils2.get_current_authuser used code like: if hasattr(tg.tmpl_context, 'authuser'): Python 2 hasattr will call __getattr__ and return False if it throws any exception. (It would thus catch the TypeError and silently fall through to use the default user None.) This hasattr behavior is confusing and hard to use correctly. Here, it was used incorrectly. It has been common practice to work around by using something like: getattr(x, y, None) is not None Python 3 hasattr fixed this flaw and only catches AttributeError. The TypeError would thus (rightfully) be propagated. That is a change that must be handled when introducing py3 support. The get_current_authuser code could more clearly and simple and py3-compatible be written as: return getattr(tmpl_context, 'authuser', None) - but then we also have to handle the TypeError explicitly ... which we are happy to do.
author Mads Kiilerich <mads@kiilerich.com>
date Fri, 31 Jan 2020 18:48:15 +0100
parents 4b241f198cf2
children d332fca29474
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
6535
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
1 [run]
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
2 omit =
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
3 # the bin scripts are not part of the Kallithea web app
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
4 kallithea/bin/*
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
5 # we ship with no active extensions
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
6 kallithea/config/rcextensions/*
7500
ddee465a345a .coveragerc: remove reference to non-existing paster_commands dir
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 6924
diff changeset
7 # dbmigrate is not a part of the Kallithea web app
6535
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
8 kallithea/lib/dbmigrate/*
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
9 # the tests themselves should not be part of the coverage report
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
10 kallithea/tests/*
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
11 # the scm hooks are not run in the kallithea process
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
12 kallithea/config/post_receive_tmpl.py
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
13 kallithea/config/pre_receive_tmpl.py
6924
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
14
7501
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
15 # same omit lines should be present in sections 'run' and 'report'
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
16 [report]
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
17 omit =
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
18 # the bin scripts are not part of the Kallithea web app
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
19 kallithea/bin/*
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
20 # we ship with no active extensions
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
21 kallithea/config/rcextensions/*
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
22 # dbmigrate is not a part of the Kallithea web app
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
23 kallithea/lib/dbmigrate/*
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
24 # the tests themselves should not be part of the coverage report
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
25 kallithea/tests/*
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
26 # the scm hooks are not run in the kallithea process
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
27 kallithea/config/post_receive_tmpl.py
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
28 kallithea/config/pre_receive_tmpl.py
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
29
6924
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
30 [paths]
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
31 source =
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
32 kallithea/
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
33 **/workspace/*/kallithea