Mercurial > kallithea
annotate MIT-Permissive-License.txt @ 8163:24e1099e4f29
py3: make get_current_authuser handle missing tg context consistently and explicitly
tg context handling ends up using
tg.support.registry.StackedObjectProxy._current_obj for attribute access ...
which if no context has been pushed will end up in:
raise TypeError(
'No object (name: %s) has been registered for this '
'thread' % self.____name__)
utils2.get_current_authuser used code like:
if hasattr(tg.tmpl_context, 'authuser'):
Python 2 hasattr will call __getattr__ and return False if it throws any
exception. (It would thus catch the TypeError and silently fall through to use
the default user None.) This hasattr behavior is confusing and hard to use
correctly. Here, it was used incorrectly. It has been common practice to work
around by using something like:
getattr(x, y, None) is not None
Python 3 hasattr fixed this flaw and only catches AttributeError. The TypeError
would thus (rightfully) be propagated. That is a change that must be handled
when introducing py3 support.
The get_current_authuser code could more clearly and simple and py3-compatible
be written as:
return getattr(tmpl_context, 'authuser', None)
- but then we also have to handle the TypeError explicitly ... which we are
happy to do.
author | Mads Kiilerich <mads@kiilerich.com> |
---|---|
date | Fri, 31 Jan 2020 18:48:15 +0100 |
parents | 08baa849c8a8 |
children |
rev | line source |
---|---|
4119
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
1 Permission is hereby granted, free of charge, to any person obtaining a copy |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
2 of this software and associated documentation files (the "Software"), to deal |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
3 in the Software without restriction, including without limitation the rights |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
4 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
5 copies of the Software, and to permit persons to whom the Software is |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
6 furnished to do so, subject to the following conditions: |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
7 |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
8 The above copyright notice and this permission notice shall be included in |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
9 all copies or substantial portions of the Software. |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
10 |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
11 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
12 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
13 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
14 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
15 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
16 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE |
08baa849c8a8
Add MIT-Permissive-License.txt
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
diff
changeset
|
17 SOFTWARE. |