Mercurial > kallithea
annotate setup.cfg @ 8163:24e1099e4f29
py3: make get_current_authuser handle missing tg context consistently and explicitly
tg context handling ends up using
tg.support.registry.StackedObjectProxy._current_obj for attribute access ...
which if no context has been pushed will end up in:
raise TypeError(
'No object (name: %s) has been registered for this '
'thread' % self.____name__)
utils2.get_current_authuser used code like:
if hasattr(tg.tmpl_context, 'authuser'):
Python 2 hasattr will call __getattr__ and return False if it throws any
exception. (It would thus catch the TypeError and silently fall through to use
the default user None.) This hasattr behavior is confusing and hard to use
correctly. Here, it was used incorrectly. It has been common practice to work
around by using something like:
getattr(x, y, None) is not None
Python 3 hasattr fixed this flaw and only catches AttributeError. The TypeError
would thus (rightfully) be propagated. That is a change that must be handled
when introducing py3 support.
The get_current_authuser code could more clearly and simple and py3-compatible
be written as:
return getattr(tmpl_context, 'authuser', None)
- but then we also have to handle the TypeError explicitly ... which we are
happy to do.
author | Mads Kiilerich <mads@kiilerich.com> |
---|---|
date | Fri, 31 Jan 2020 18:48:15 +0100 |
parents | 0a2d85671b59 |
children | 278cc5936ed5 |
rev | line source |
---|---|
0 | 1 [egg_info] |
5379
1949ece749ce
cleanup: fix whitespace in CONTRIBUTORS (and other forgotten files) too
Mads Kiilerich <madski@unity3d.com>
parents:
5146
diff
changeset
|
2 tag_build = |
4988
acaa02179aeb
setup.cfg: update checked-in version to match how sdist writes it
Mads Kiilerich <madski@unity3d.com>
parents:
4257
diff
changeset
|
3 tag_svn_revision = 0 |
acaa02179aeb
setup.cfg: update checked-in version to match how sdist writes it
Mads Kiilerich <madski@unity3d.com>
parents:
4257
diff
changeset
|
4 tag_date = 0 |
0 | 5 |
5700
d88077fae3d6
pytest migration: switch to pytest; remove nose support
Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
parents:
5416
diff
changeset
|
6 [aliases] |
d88077fae3d6
pytest migration: switch to pytest; remove nose support
Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
parents:
5416
diff
changeset
|
7 test = pytest |
5061
8c1258f69892
tests: Move pytest config (norecursedirs) from tox.ini to setup.cfg
Mads Kiilerich <madski@unity3d.com>
parents:
4988
diff
changeset
|
8 |
0 | 9 [compile_catalog] |
4186
7e5f8c12a3fc
First step in two-part process to rename directories to kallithea.
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
3960
diff
changeset
|
10 domain = kallithea |
7e5f8c12a3fc
First step in two-part process to rename directories to kallithea.
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
3960
diff
changeset
|
11 directory = kallithea/i18n |
0 | 12 statistics = true |
13 | |
14 [extract_messages] | |
15 add_comments = TRANSLATORS: | |
4186
7e5f8c12a3fc
First step in two-part process to rename directories to kallithea.
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
3960
diff
changeset
|
16 output_file = kallithea/i18n/kallithea.pot |
4248
10df28cbcce7
Correct contact address for translations.
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
4208
diff
changeset
|
17 msgid-bugs-address = translations@kallithea-scm.org |
4208
ad38f9f93b3b
Correct licensing information in individual files.
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
4186
diff
changeset
|
18 copyright-holder = Various authors, licensing as GPLv3 |
0 | 19 |
20 [init_catalog] | |
4186
7e5f8c12a3fc
First step in two-part process to rename directories to kallithea.
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
3960
diff
changeset
|
21 domain = kallithea |
7e5f8c12a3fc
First step in two-part process to rename directories to kallithea.
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
3960
diff
changeset
|
22 input_file = kallithea/i18n/kallithea.pot |
7e5f8c12a3fc
First step in two-part process to rename directories to kallithea.
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
3960
diff
changeset
|
23 output_dir = kallithea/i18n |
0 | 24 |
25 [update_catalog] | |
4186
7e5f8c12a3fc
First step in two-part process to rename directories to kallithea.
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
3960
diff
changeset
|
26 domain = kallithea |
7e5f8c12a3fc
First step in two-part process to rename directories to kallithea.
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
3960
diff
changeset
|
27 input_file = kallithea/i18n/kallithea.pot |
7e5f8c12a3fc
First step in two-part process to rename directories to kallithea.
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents:
3960
diff
changeset
|
28 output_dir = kallithea/i18n |
0 | 29 previous = true |
592
0a48c1ec04fc
#37 fixed json imports for python2.5
Marcin Kuzminski <marcin@python-works.com>
parents:
589
diff
changeset
|
30 |
0a48c1ec04fc
#37 fixed json imports for python2.5
Marcin Kuzminski <marcin@python-works.com>
parents:
589
diff
changeset
|
31 [build_sphinx] |
0a48c1ec04fc
#37 fixed json imports for python2.5
Marcin Kuzminski <marcin@python-works.com>
parents:
589
diff
changeset
|
32 source-dir = docs/ |
4988
acaa02179aeb
setup.cfg: update checked-in version to match how sdist writes it
Mads Kiilerich <madski@unity3d.com>
parents:
4257
diff
changeset
|
33 build-dir = docs/_build |
acaa02179aeb
setup.cfg: update checked-in version to match how sdist writes it
Mads Kiilerich <madski@unity3d.com>
parents:
4257
diff
changeset
|
34 all_files = 1 |
592
0a48c1ec04fc
#37 fixed json imports for python2.5
Marcin Kuzminski <marcin@python-works.com>
parents:
589
diff
changeset
|
35 |
0a48c1ec04fc
#37 fixed json imports for python2.5
Marcin Kuzminski <marcin@python-works.com>
parents:
589
diff
changeset
|
36 [upload_sphinx] |
3932
3483de9d11e5
updated pot file and extract_messages defaults
Marcin Kuzminski <marcin@python-works.com>
parents:
3158
diff
changeset
|
37 upload-dir = docs/_build/html |