annotate tox.ini @ 8163:24e1099e4f29

py3: make get_current_authuser handle missing tg context consistently and explicitly tg context handling ends up using tg.support.registry.StackedObjectProxy._current_obj for attribute access ... which if no context has been pushed will end up in: raise TypeError( 'No object (name: %s) has been registered for this ' 'thread' % self.____name__) utils2.get_current_authuser used code like: if hasattr(tg.tmpl_context, 'authuser'): Python 2 hasattr will call __getattr__ and return False if it throws any exception. (It would thus catch the TypeError and silently fall through to use the default user None.) This hasattr behavior is confusing and hard to use correctly. Here, it was used incorrectly. It has been common practice to work around by using something like: getattr(x, y, None) is not None Python 3 hasattr fixed this flaw and only catches AttributeError. The TypeError would thus (rightfully) be propagated. That is a change that must be handled when introducing py3 support. The get_current_authuser code could more clearly and simple and py3-compatible be written as: return getattr(tmpl_context, 'authuser', None) - but then we also have to handle the TypeError explicitly ... which we are happy to do.
author Mads Kiilerich <mads@kiilerich.com>
date Fri, 31 Jan 2020 18:48:15 +0100
parents ab30729c735c
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
5015
2481c0a1ed31 Add tox.ini
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
diff changeset
1 [tox]
5389
768989c595aa tox.ini: declare 1.8 as minimum tox version
Mads Kiilerich <madski@unity3d.com>
parents: 5061
diff changeset
2 minversion = 1.8
7708
ab30729c735c setup: drop support for Python 2.6
Mads Kiilerich <mads@kiilerich.com>
parents: 6026
diff changeset
3 envlist = py27-pytest
5015
2481c0a1ed31 Add tox.ini
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
diff changeset
4
2481c0a1ed31 Add tox.ini
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
diff changeset
5 [testenv]
5017
9c5e6984bd0e tox.ini: Set PYTHONHASHSEED = 0
Marc Abramowitz <marc@marc-abramowitz.com>
parents: 5016
diff changeset
6 setenv =
9c5e6984bd0e tox.ini: Set PYTHONHASHSEED = 0
Marc Abramowitz <marc@marc-abramowitz.com>
parents: 5016
diff changeset
7 PYTHONHASHSEED = 0
5016
46662961d58d tox.ini: Add nose and pytest deps
Marc Abramowitz <marc@marc-abramowitz.com>
parents: 5015
diff changeset
8 deps =
6026
dd676fdeda0f setup: move test dependencies to dev_requirements.txt to make them optional
Mads Kiilerich <madski@unity3d.com>
parents: 5995
diff changeset
9 -r{toxinidir}/dev_requirements.txt
5995
b2195895bbd7 tests: install pam and ldap modules when testing with tox
Mads Kiilerich <madski@unity3d.com>
parents: 5699
diff changeset
10 python-ldap
b2195895bbd7 tests: install pam and ldap modules when testing with tox
Mads Kiilerich <madski@unity3d.com>
parents: 5699
diff changeset
11 python-pam
5016
46662961d58d tox.ini: Add nose and pytest deps
Marc Abramowitz <marc@marc-abramowitz.com>
parents: 5015
diff changeset
12 commands =
46662961d58d tox.ini: Add nose and pytest deps
Marc Abramowitz <marc@marc-abramowitz.com>
parents: 5015
diff changeset
13 pytest: py.test {posargs}