annotate init.d/kallithea-upstart.conf @ 8886:3d7ba590f6f5

auth: only use X- headers instead of REMOTE_ADDR if explicitly told so in remote_addr_header Before, X-Forwarded-For (and others) headers would *always* be trusted blindly, also in setups without a proxy server. It would thus in some cases be possible for users to fake their IP, and thus potentially be possible to bypass IP restrictions configured in Kallithea. Fixed by making it configurable which WSGI environment variable to use for the remote address. Users can configure remote_addr_header to for example HTTP_X_FORWARDED_FOR instead of using the default REMOTE_ADDR. This change is a bit similar to what is going on in the https_fixup middleware, but is doing a bit more of what for example is happening in similar code in werkzeug/middleware/proxy_fix.py .
author Mads Kiilerich <mads@kiilerich.com>
date Sun, 09 May 2021 22:34:02 +0200
parents 2c3d30095d5e
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
4190
99ad9d0af1a3 Rename init scripts and fix references inside them
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents: 1811
diff changeset
1 # kallithea - run the kallithea daemon as an upstart job
99ad9d0af1a3 Rename init scripts and fix references inside them
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents: 1811
diff changeset
2 # Change variables/paths as necessary and place file /etc/init/kallithea.conf
99ad9d0af1a3 Rename init scripts and fix references inside them
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents: 1811
diff changeset
3 # start/stop/restart as normal upstart job (ie: $ start kallithea)
1803
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
4
6370
e285bb7abb28 scripts: apply whitespace cleanup to more files - opt out instead of opt in
Mads Kiilerich <mads@kiilerich.com>
parents: 4212
diff changeset
5 description "Kallithea Mercurial Server"
e285bb7abb28 scripts: apply whitespace cleanup to more files - opt out instead of opt in
Mads Kiilerich <mads@kiilerich.com>
parents: 4212
diff changeset
6 author "Matt Zuba <matt.zuba@goodwillaz.org"
1803
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
7
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
8 start on (local-filesystems and runlevel [2345])
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
9 stop on runlevel [!2345]
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
10
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
11 respawn
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
12
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
13 umask 0022
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
14
4190
99ad9d0af1a3 Rename init scripts and fix references inside them
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents: 1811
diff changeset
15 env PIDFILE=/var/hg/kallithea/kallithea.pid
99ad9d0af1a3 Rename init scripts and fix references inside them
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents: 1811
diff changeset
16 env LOGFILE=/var/hg/kallithea/log/kallithea.log
99ad9d0af1a3 Rename init scripts and fix references inside them
Bradley M. Kuhn <bkuhn@sfconservancy.org>
parents: 1811
diff changeset
17 env APPINI=/var/hg/kallithea/production.ini
1803
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
18 env HOME=/var/hg
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
19 env USER=hg
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
20 env GROUP=hg
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
21
6554
2c3d30095d5e gearbox: replace paster with something TurboGears2-ish that still works with the Pylons stack
Mads Kiilerich <madski@unity3d.com>
parents: 6370
diff changeset
22 exec /var/hg/.virtualenvs/kallithea/bin/gearbox serve --user=$USER --group=$GROUP --pid-file=$PIDFILE --log-file=$LOGFILE -c $APPINI
1803
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
23
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
24 post-stop script
6370
e285bb7abb28 scripts: apply whitespace cleanup to more files - opt out instead of opt in
Mads Kiilerich <mads@kiilerich.com>
parents: 4212
diff changeset
25 rm -f $PIDFILE
1803
96789e1b0064 Debian/Ubuntu upstart script
Matt Zuba <matt.zuba@goodwillaz.org>
parents:
diff changeset
26 end script