annotate .coveragerc @ 8908:8993d401575b stable

files: fix raw download of repo files with names with unicode points above 256 in name Raw download had apparently only been tested with non-ascii characters that were latin1. That was apparently a (too) simple case that worked without crashing. Files with unicode code points above 256 in their name would fail to download, when Waitress failed like this, trying to get a real byte string by encoding WSGI headers to latin1: UnicodeEncodeError: 'latin-1' codec can't encode characters in position 84-85: ordinal not in range(256) HTTP headers are of course byte strings on the network, but Python3 WSGI does unfortunately neither expose it as bytes nor as unicode strings to be encoded as utf-8. Instead, it uses unicode strings with byte values encoded as code points 0-255. That is achieved by decoding the utf-8 encoded bytes as latin1. For raw downloads, the recommended download filename is provided in the Content-Disposition header. The problem is that it was provided as a real unicode string. Fixed by applying the "proper" latin1-decoding of a utf8-encoding.
author Mads Kiilerich <mads@kiilerich.com>
date Mon, 07 Feb 2022 19:07:08 +0100
parents d332fca29474
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
6535
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
1 [run]
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
2 omit =
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
3 # the bin scripts are not part of the Kallithea web app
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
4 kallithea/bin/*
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
5 # we ship with no active extensions
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
6 kallithea/config/rcextensions/*
7500
ddee465a345a .coveragerc: remove reference to non-existing paster_commands dir
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 6924
diff changeset
7 # dbmigrate is not a part of the Kallithea web app
6535
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
8 kallithea/lib/dbmigrate/*
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
9 # the tests themselves should not be part of the coverage report
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
10 kallithea/tests/*
6924
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
11
7501
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
12 # same omit lines should be present in sections 'run' and 'report'
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
13 [report]
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
14 omit =
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
15 # the bin scripts are not part of the Kallithea web app
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
16 kallithea/bin/*
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
17 # we ship with no active extensions
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
18 kallithea/config/rcextensions/*
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
19 # dbmigrate is not a part of the Kallithea web app
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
20 kallithea/lib/dbmigrate/*
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
21 # the tests themselves should not be part of the coverage report
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
22 kallithea/tests/*
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
23
6924
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
24 [paths]
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
25 source =
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
26 kallithea/
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
27 **/workspace/*/kallithea