Mercurial > kallithea
annotate dev_requirements.txt @ 8908:8993d401575b stable
files: fix raw download of repo files with names with unicode points above 256 in name
Raw download had apparently only been tested with non-ascii characters that
were latin1. That was apparently a (too) simple case that worked without
crashing.
Files with unicode code points above 256 in their name would fail to download,
when Waitress failed like this, trying to get a real byte string by encoding
WSGI headers to latin1:
UnicodeEncodeError: 'latin-1' codec can't encode characters in position 84-85: ordinal not in range(256)
HTTP headers are of course byte strings on the network, but Python3 WSGI does
unfortunately neither expose it as bytes nor as unicode strings to be encoded
as utf-8. Instead, it uses unicode strings with byte values encoded as code
points 0-255. That is achieved by decoding the utf-8 encoded bytes as latin1.
For raw downloads, the recommended download filename is provided in the
Content-Disposition header. The problem is that it was provided as a real
unicode string.
Fixed by applying the "proper" latin1-decoding of a utf8-encoding.
author | Mads Kiilerich <mads@kiilerich.com> |
---|---|
date | Mon, 07 Feb 2022 19:07:08 +0100 |
parents | 68eee0e7f4f5 |
children | 5f4a108eed54 |
rev | line source |
---|---|
8557
42312c8d070d
setup: bump version numbers to current max
Mads Kiilerich <mads@kiilerich.com>
parents:
8240
diff
changeset
|
1 pytest >= 4.6.6, < 5.5 |
7900
4dad662fe6fd
dev_requirements.txt: bump minimum pytest versions to a working set
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7810
diff
changeset
|
2 pytest-sugar >= 0.9.2, < 0.10 |
4dad662fe6fd
dev_requirements.txt: bump minimum pytest versions to a working set
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7810
diff
changeset
|
3 pytest-benchmark >= 3.2.2, < 3.3 |
4dad662fe6fd
dev_requirements.txt: bump minimum pytest versions to a working set
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7810
diff
changeset
|
4 pytest-localserver >= 0.5.0, < 0.6 |
8228
d122a9532630
setup: bump version numbers to current max
Mads Kiilerich <mads@kiilerich.com>
parents:
8137
diff
changeset
|
5 mock >= 3.0.0, < 4.1 |
8557
42312c8d070d
setup: bump version numbers to current max
Mads Kiilerich <mads@kiilerich.com>
parents:
8240
diff
changeset
|
6 Sphinx >= 1.8.0, < 3.1 |
8137
268c47a1a93d
setup: bump webtest minimum version to 2.0.6 to get py3 stdlib support
Mads Kiilerich <mads@kiilerich.com>
parents:
7929
diff
changeset
|
7 WebTest >= 2.0.6, < 2.1 |
8599
68eee0e7f4f5
isort: upgrade to 5.1.2
Mads Kiilerich <mads@kiilerich.com>
parents:
8557
diff
changeset
|
8 isort == 5.1.2 |
8557
42312c8d070d
setup: bump version numbers to current max
Mads Kiilerich <mads@kiilerich.com>
parents:
8240
diff
changeset
|
9 pyflakes == 2.2.0 |