Mercurial > kallithea
annotate tox.ini @ 8908:8993d401575b stable
files: fix raw download of repo files with names with unicode points above 256 in name
Raw download had apparently only been tested with non-ascii characters that
were latin1. That was apparently a (too) simple case that worked without
crashing.
Files with unicode code points above 256 in their name would fail to download,
when Waitress failed like this, trying to get a real byte string by encoding
WSGI headers to latin1:
UnicodeEncodeError: 'latin-1' codec can't encode characters in position 84-85: ordinal not in range(256)
HTTP headers are of course byte strings on the network, but Python3 WSGI does
unfortunately neither expose it as bytes nor as unicode strings to be encoded
as utf-8. Instead, it uses unicode strings with byte values encoded as code
points 0-255. That is achieved by decoding the utf-8 encoded bytes as latin1.
For raw downloads, the recommended download filename is provided in the
Content-Disposition header. The problem is that it was provided as a real
unicode string.
Fixed by applying the "proper" latin1-decoding of a utf8-encoding.
author | Mads Kiilerich <mads@kiilerich.com> |
---|---|
date | Mon, 07 Feb 2022 19:07:08 +0100 |
parents | ab30729c735c |
children |
rev | line source |
---|---|
5015 | 1 [tox] |
5389
768989c595aa
tox.ini: declare 1.8 as minimum tox version
Mads Kiilerich <madski@unity3d.com>
parents:
5061
diff
changeset
|
2 minversion = 1.8 |
7708
ab30729c735c
setup: drop support for Python 2.6
Mads Kiilerich <mads@kiilerich.com>
parents:
6026
diff
changeset
|
3 envlist = py27-pytest |
5015 | 4 |
5 [testenv] | |
5017
9c5e6984bd0e
tox.ini: Set PYTHONHASHSEED = 0
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5016
diff
changeset
|
6 setenv = |
9c5e6984bd0e
tox.ini: Set PYTHONHASHSEED = 0
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5016
diff
changeset
|
7 PYTHONHASHSEED = 0 |
5016
46662961d58d
tox.ini: Add nose and pytest deps
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5015
diff
changeset
|
8 deps = |
6026
dd676fdeda0f
setup: move test dependencies to dev_requirements.txt to make them optional
Mads Kiilerich <madski@unity3d.com>
parents:
5995
diff
changeset
|
9 -r{toxinidir}/dev_requirements.txt |
5995
b2195895bbd7
tests: install pam and ldap modules when testing with tox
Mads Kiilerich <madski@unity3d.com>
parents:
5699
diff
changeset
|
10 python-ldap |
b2195895bbd7
tests: install pam and ldap modules when testing with tox
Mads Kiilerich <madski@unity3d.com>
parents:
5699
diff
changeset
|
11 python-pam |
5016
46662961d58d
tox.ini: Add nose and pytest deps
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5015
diff
changeset
|
12 commands = |
46662961d58d
tox.ini: Add nose and pytest deps
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5015
diff
changeset
|
13 pytest: py.test {posargs} |