Mercurial > kallithea
annotate tox.ini @ 6217:8d98924c58b1
tests: add as little code as possible in __init__.py
kallithea/tests/__init__.py contained quite a lot of code, including the test
base class TestController. This in itself may be considered bad practice.
Specifically, this poses a problem when using pytest 3.0+, in which asserts
in some files are not automatically rewritten to give improved assert
output. That problem can be fixed by explicitly registering such files for
assertion rewriting, but that register call should be executed _before_ said
files are imported. I.e. if the register call is in
kallithea/tests/__init__.py, assert calls in __init__.py itself can not be
rewritten.
Since the TestController base class does effectively contain asserts, and we
do not want to execute the register call from somewhere outside the
kallithea/tests directory, we need to move the TestController class to
another file (kallithea/tests/base.py) so we can have a register call in
__init__.py before loading base.py.
While not strictly necessary to fix the mentioned pytest problem, we take
the opportunity to fully clean __init__.py and move everything to
the new kallithea/tests/base.py. While doing so, unnecessary imports are
removed, and imports are ordered alphabetically. Explicit imports of symbols
from modules that were already imported as a whole, are removed in favor of
fully qualifying the references (e.g. tempfile._RandomNameSequence).
author | Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> |
---|---|
date | Sun, 18 Sep 2016 21:44:21 +0200 |
parents | dd676fdeda0f |
children | ab30729c735c |
rev | line source |
---|---|
5015 | 1 [tox] |
5389
768989c595aa
tox.ini: declare 1.8 as minimum tox version
Mads Kiilerich <madski@unity3d.com>
parents:
5061
diff
changeset
|
2 minversion = 1.8 |
5699
6a83b399bb3c
pytest migration: remove nose from tox configuration
Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
parents:
5389
diff
changeset
|
3 envlist = py{26,27}-pytest |
5015 | 4 |
5 [testenv] | |
5017
9c5e6984bd0e
tox.ini: Set PYTHONHASHSEED = 0
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5016
diff
changeset
|
6 setenv = |
9c5e6984bd0e
tox.ini: Set PYTHONHASHSEED = 0
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5016
diff
changeset
|
7 PYTHONHASHSEED = 0 |
5016
46662961d58d
tox.ini: Add nose and pytest deps
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5015
diff
changeset
|
8 deps = |
6026
dd676fdeda0f
setup: move test dependencies to dev_requirements.txt to make them optional
Mads Kiilerich <madski@unity3d.com>
parents:
5995
diff
changeset
|
9 -r{toxinidir}/dev_requirements.txt |
dd676fdeda0f
setup: move test dependencies to dev_requirements.txt to make them optional
Mads Kiilerich <madski@unity3d.com>
parents:
5995
diff
changeset
|
10 py26-pytest: unittest2 |
5995
b2195895bbd7
tests: install pam and ldap modules when testing with tox
Mads Kiilerich <madski@unity3d.com>
parents:
5699
diff
changeset
|
11 python-ldap |
b2195895bbd7
tests: install pam and ldap modules when testing with tox
Mads Kiilerich <madski@unity3d.com>
parents:
5699
diff
changeset
|
12 python-pam |
5016
46662961d58d
tox.ini: Add nose and pytest deps
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5015
diff
changeset
|
13 commands = |
46662961d58d
tox.ini: Add nose and pytest deps
Marc Abramowitz <marc@marc-abramowitz.com>
parents:
5015
diff
changeset
|
14 pytest: py.test {posargs} |