annotate .coveragerc @ 8769:d35d14b05b82

diff: handle some escaped characters in Git diffs There are some odd characters (like \r and \n) that the Kallithea UI doesn't allow in filenames in repos. Kallithea (through the routes module) will fail to generate URLs when browsing Files. That is a known limitation with minimal real-world impact, non-trivial to work around or fix. There are very few relevant use cases for tracking files with odd filenames. \t is valid but is hard to render in a meaningful way in the UI. And ASCII characters like \ and " are not usable on Windows and should just be avoided. Kallithea would parse Git diffs with odd characers incorrectly or fail, even before hitting the known limitation. With this change, Kallithea will parse diffs with odd filenames correctly (and then hit the limitation). Git will quote odd filenames and escape the odd characters when emitting diffs. (Mercurial does by design not allow \r and \n , and Mercurial will thus never have to quote file names in diffs.) Quotes are already handled (and ignored). With this change, Kallithea will handle \ unescaping of \\ and \", the usual letters like \r and \n and \t, and octal numbers like \033 (for ESC) . Filenames with \ and " will work perfectly (when not on Windows). Filenames with \t and ESC will work fine, but without helpful display in the UI. Filenames with \r and \n will still make the UI fail when trying to generate URLs. Thanks to stypr of Flatt Security for raising this.
author Mads Kiilerich <mads@kiilerich.com>
date Sat, 14 Nov 2020 15:41:39 +0100
parents d332fca29474
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
6535
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
1 [run]
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
2 omit =
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
3 # the bin scripts are not part of the Kallithea web app
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
4 kallithea/bin/*
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
5 # we ship with no active extensions
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
6 kallithea/config/rcextensions/*
7500
ddee465a345a .coveragerc: remove reference to non-existing paster_commands dir
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 6924
diff changeset
7 # dbmigrate is not a part of the Kallithea web app
6535
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
8 kallithea/lib/dbmigrate/*
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
9 # the tests themselves should not be part of the coverage report
7790b34a0cef tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff changeset
10 kallithea/tests/*
6924
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
11
7501
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
12 # same omit lines should be present in sections 'run' and 'report'
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
13 [report]
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
14 omit =
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
15 # the bin scripts are not part of the Kallithea web app
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
16 kallithea/bin/*
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
17 # we ship with no active extensions
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
18 kallithea/config/rcextensions/*
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
19 # dbmigrate is not a part of the Kallithea web app
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
20 kallithea/lib/dbmigrate/*
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
21 # the tests themselves should not be part of the coverage report
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
22 kallithea/tests/*
4b241f198cf2 .coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents: 7500
diff changeset
23
6924
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
24 [paths]
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
25 source =
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
26 kallithea/
0acb46763886 jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents: 6535
diff changeset
27 **/workspace/*/kallithea