Mercurial > kallithea
annotate .coveragerc @ 8455:d727e81e0097 stable
vcs: fix cloning remote repository with HTTP authentication (Issue #379)
Using a remote clone URI of
http://user:pass@host/...
triggered an exception:
...
E File ".../kallithea/lib/utils.py", line 256, in is_valid_repo_uri
E GitRepository._check_url(url)
E File ".../kallithea/lib/vcs/backends/git/repository.py", line 183, in _check_url
E passmgr.add_password(*authinfo)
E File "/usr/lib/python3.7/urllib/request.py", line 848, in add_password
E self.reduce_uri(u, default_port) for u in uri)
E File "/usr/lib/python3.7/urllib/request.py", line 848, in <genexpr>
E self.reduce_uri(u, default_port) for u in uri)
E File "/usr/lib/python3.7/urllib/request.py", line 875, in reduce_uri
E host, port = splitport(authority)
E File "/usr/lib/python3.7/urllib/parse.py", line 1022, in splitport
E match = _portprog.fullmatch(host)
E TypeError: cannot use a string pattern on a bytes-like object
The authinfo tuple is obtained via mercurial.util.url, which unfortunately
returns a tuple of bytes whereas urllib expects strings.
It seems that mercurial internally has some more hacking around urllib as
urllibcompat.py, which we don't use.
Therefore, transform the bytes into strings before passing authinfo to
urllib. As the realm can be None, we need to check it specifically otherwise
safe_str would return a string 'None'.
A basic test that catches the mentioned problem is added, even though it
does not actually test that cloning with auth info will actually work (it
only tests that it fails cleanly if the URI is not reachable).
Additionally, one use of 'test_uri' in hg/repository.py still needed to be
transformed from bytes to string. For git this was already ok.
author | Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> |
---|---|
date | Wed, 22 Jul 2020 21:55:57 +0200 |
parents | 4b241f198cf2 |
children | d332fca29474 |
rev | line source |
---|---|
6535
7790b34a0cef
tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff
changeset
|
1 [run] |
7790b34a0cef
tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff
changeset
|
2 omit = |
7790b34a0cef
tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff
changeset
|
3 # the bin scripts are not part of the Kallithea web app |
7790b34a0cef
tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff
changeset
|
4 kallithea/bin/* |
7790b34a0cef
tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff
changeset
|
5 # we ship with no active extensions |
7790b34a0cef
tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff
changeset
|
6 kallithea/config/rcextensions/* |
7500
ddee465a345a
.coveragerc: remove reference to non-existing paster_commands dir
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
6924
diff
changeset
|
7 # dbmigrate is not a part of the Kallithea web app |
6535
7790b34a0cef
tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff
changeset
|
8 kallithea/lib/dbmigrate/* |
7790b34a0cef
tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff
changeset
|
9 # the tests themselves should not be part of the coverage report |
7790b34a0cef
tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff
changeset
|
10 kallithea/tests/* |
7790b34a0cef
tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff
changeset
|
11 # the scm hooks are not run in the kallithea process |
7790b34a0cef
tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff
changeset
|
12 kallithea/config/post_receive_tmpl.py |
7790b34a0cef
tests: add pytest-cov .coveragerc file
domruf <dominikruf@gmail.com>
parents:
diff
changeset
|
13 kallithea/config/pre_receive_tmpl.py |
6924
0acb46763886
jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents:
6535
diff
changeset
|
14 |
7501
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
15 # same omit lines should be present in sections 'run' and 'report' |
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
16 [report] |
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
17 omit = |
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
18 # the bin scripts are not part of the Kallithea web app |
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
19 kallithea/bin/* |
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
20 # we ship with no active extensions |
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
21 kallithea/config/rcextensions/* |
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
22 # dbmigrate is not a part of the Kallithea web app |
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
23 kallithea/lib/dbmigrate/* |
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
24 # the tests themselves should not be part of the coverage report |
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
25 kallithea/tests/* |
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
26 # the scm hooks are not run in the kallithea process |
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
27 kallithea/config/post_receive_tmpl.py |
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
28 kallithea/config/pre_receive_tmpl.py |
4b241f198cf2
.coveragerc: fix reporting of coverage to match what is run
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
parents:
7500
diff
changeset
|
29 |
6924
0acb46763886
jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents:
6535
diff
changeset
|
30 [paths] |
0acb46763886
jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents:
6535
diff
changeset
|
31 source = |
0acb46763886
jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents:
6535
diff
changeset
|
32 kallithea/ |
0acb46763886
jenkinsfile: combine coverage files from different DB runs
domruf <dominikruf@gmail.com>
parents:
6535
diff
changeset
|
33 **/workspace/*/kallithea |