comparison rhodecode/lib/db_manage.py @ 3631:10b4e34841a4 beta

Don't catch all exceptions
author Marcin Kuzminski <marcin@python-works.com>
date Thu, 28 Mar 2013 03:34:36 +0100
parents 260a7a01b054
children 658ccf9727ef
comparison
equal deleted inserted replaced
3630:5d8cda8e63dc 3631:10b4e34841a4
317 paths.ui_value = paths.ui_value.replace('*', '') 317 paths.ui_value = paths.ui_value.replace('*', '')
318 318
319 try: 319 try:
320 self.sa.add(paths) 320 self.sa.add(paths)
321 self.sa.commit() 321 self.sa.commit()
322 except: 322 except Exception:
323 self.sa.rollback() 323 self.sa.rollback()
324 raise 324 raise
325 325
326 def fix_default_user(self): 326 def fix_default_user(self):
327 """ 327 """
337 def_user.email = 'anonymous@rhodecode.org' 337 def_user.email = 'anonymous@rhodecode.org'
338 338
339 try: 339 try:
340 self.sa.add(def_user) 340 self.sa.add(def_user)
341 self.sa.commit() 341 self.sa.commit()
342 except: 342 except Exception:
343 self.sa.rollback() 343 self.sa.rollback()
344 raise 344 raise
345 345
346 def fix_settings(self): 346 def fix_settings(self):
347 """ 347 """
351 hgsettings3 = RhodeCodeSetting('ga_code', '') 351 hgsettings3 = RhodeCodeSetting('ga_code', '')
352 352
353 try: 353 try:
354 self.sa.add(hgsettings3) 354 self.sa.add(hgsettings3)
355 self.sa.commit() 355 self.sa.commit()
356 except: 356 except Exception:
357 self.sa.rollback() 357 self.sa.rollback()
358 raise 358 raise
359 359
360 def admin_prompt(self, second=False): 360 def admin_prompt(self, second=False):
361 if not self.tests: 361 if not self.tests: