Mercurial > kallithea
comparison rhodecode/lib/middleware/simplegit.py @ 3631:10b4e34841a4 beta
Don't catch all exceptions
author | Marcin Kuzminski <marcin@python-works.com> |
---|---|
date | Thu, 28 Mar 2013 03:34:36 +0100 |
parents | 260a7a01b054 |
children | 336184b9f4cf |
comparison
equal
deleted
inserted
replaced
3630:5d8cda8e63dc | 3631:10b4e34841a4 |
---|---|
120 # EXTRACT REPOSITORY NAME FROM ENV | 120 # EXTRACT REPOSITORY NAME FROM ENV |
121 #====================================================================== | 121 #====================================================================== |
122 try: | 122 try: |
123 repo_name = self.__get_repository(environ) | 123 repo_name = self.__get_repository(environ) |
124 log.debug('Extracted repo name is %s' % repo_name) | 124 log.debug('Extracted repo name is %s' % repo_name) |
125 except: | 125 except Exception: |
126 return HTTPInternalServerError()(environ, start_response) | 126 return HTTPInternalServerError()(environ, start_response) |
127 | 127 |
128 # quick check if that dir exists... | 128 # quick check if that dir exists... |
129 if not is_valid_repo(repo_name, self.basepath, 'git'): | 129 if not is_valid_repo(repo_name, self.basepath, 'git'): |
130 return HTTPNotFound()(environ, start_response) | 130 return HTTPNotFound()(environ, start_response) |
176 try: | 176 try: |
177 user = self.__get_user(username) | 177 user = self.__get_user(username) |
178 if user is None or not user.active: | 178 if user is None or not user.active: |
179 return HTTPForbidden()(environ, start_response) | 179 return HTTPForbidden()(environ, start_response) |
180 username = user.username | 180 username = user.username |
181 except: | 181 except Exception: |
182 log.error(traceback.format_exc()) | 182 log.error(traceback.format_exc()) |
183 return HTTPInternalServerError()(environ, start_response) | 183 return HTTPInternalServerError()(environ, start_response) |
184 | 184 |
185 #check permissions for this repository | 185 #check permissions for this repository |
186 perm = self._check_permission(action, user, repo_name, ip_addr) | 186 perm = self._check_permission(action, user, repo_name, ip_addr) |
270 :param environ: environ where PATH_INFO is stored | 270 :param environ: environ where PATH_INFO is stored |
271 """ | 271 """ |
272 try: | 272 try: |
273 environ['PATH_INFO'] = self._get_by_id(environ['PATH_INFO']) | 273 environ['PATH_INFO'] = self._get_by_id(environ['PATH_INFO']) |
274 repo_name = GIT_PROTO_PAT.match(environ['PATH_INFO']).group(1) | 274 repo_name = GIT_PROTO_PAT.match(environ['PATH_INFO']).group(1) |
275 except: | 275 except Exception: |
276 log.error(traceback.format_exc()) | 276 log.error(traceback.format_exc()) |
277 raise | 277 raise |
278 | 278 |
279 return repo_name | 279 return repo_name |
280 | 280 |