comparison rhodecode/lib/vcs/backends/git/repository.py @ 3631:10b4e34841a4 beta

Don't catch all exceptions
author Marcin Kuzminski <marcin@python-works.com>
date Thu, 28 Mar 2013 03:34:36 +0100
parents 11feddcd75bb
children 600ffde2634c
comparison
equal deleted inserted replaced
3630:5d8cda8e63dc 3631:10b4e34841a4
257 257
258 if ((is_bstr(revision) and revision.isdigit() and len(revision) < 12) 258 if ((is_bstr(revision) and revision.isdigit() and len(revision) < 12)
259 or isinstance(revision, int) or is_null(revision)): 259 or isinstance(revision, int) or is_null(revision)):
260 try: 260 try:
261 revision = self.revisions[int(revision)] 261 revision = self.revisions[int(revision)]
262 except: 262 except Exception:
263 raise ChangesetDoesNotExistError("Revision %s does not exist " 263 raise ChangesetDoesNotExistError("Revision %s does not exist "
264 "for this repository" % (revision)) 264 "for this repository" % (revision))
265 265
266 elif is_bstr(revision): 266 elif is_bstr(revision):
267 # get by branch/tag name 267 # get by branch/tag name