comparison rhodecode/model/repos_group.py @ 3631:10b4e34841a4 beta

Don't catch all exceptions
author Marcin Kuzminski <marcin@python-works.com>
date Thu, 28 Mar 2013 03:34:36 +0100
parents 94f251fda314
children 4c78a0855a17
comparison
equal deleted inserted replaced
3630:5d8cda8e63dc 3631:10b4e34841a4
160 # throw any exceptions, create filesystem dirs at the very end 160 # throw any exceptions, create filesystem dirs at the very end
161 self.sa.flush() 161 self.sa.flush()
162 self.__create_group(new_repos_group.group_name) 162 self.__create_group(new_repos_group.group_name)
163 163
164 return new_repos_group 164 return new_repos_group
165 except: 165 except Exception:
166 log.error(traceback.format_exc()) 166 log.error(traceback.format_exc())
167 raise 167 raise
168 168
169 def _update_permissions(self, repos_group, perms_new=None, 169 def _update_permissions(self, repos_group, perms_new=None,
170 perms_updates=None, recursive=False): 170 perms_updates=None, recursive=False):
281 self.sa.add(obj) 281 self.sa.add(obj)
282 282
283 self.__rename_group(old_path, new_path) 283 self.__rename_group(old_path, new_path)
284 284
285 return repos_group 285 return repos_group
286 except: 286 except Exception:
287 log.error(traceback.format_exc()) 287 log.error(traceback.format_exc())
288 raise 288 raise
289 289
290 def delete(self, repos_group, force_delete=False): 290 def delete(self, repos_group, force_delete=False):
291 repos_group = self._get_repos_group(repos_group) 291 repos_group = self._get_repos_group(repos_group)
292 try: 292 try:
293 self.sa.delete(repos_group) 293 self.sa.delete(repos_group)
294 self.__delete_group(repos_group, force_delete) 294 self.__delete_group(repos_group, force_delete)
295 except: 295 except Exception:
296 log.error('Error removing repos_group %s' % repos_group) 296 log.error('Error removing repos_group %s' % repos_group)
297 raise 297 raise
298 298
299 def delete_permission(self, repos_group, obj, obj_type, recursive): 299 def delete_permission(self, repos_group, obj, obj_type, recursive):
300 """ 300 """