comparison rhodecode/controllers/changeset.py @ 3750:244f184f5fc3 beta

moved around some code in changeset controllers to properly log which function was decorated. Before it was always index, and permission were checked twice giving unnneded overhead
author Marcin Kuzminski <marcin@python-works.com>
date Mon, 15 Apr 2013 01:01:47 +0200
parents b950b884ab87
children ce4b7023a492
comparison
equal deleted inserted replaced
3749:b950b884ab87 3750:244f184f5fc3
175 c.affected_files_cut_off = 60 175 c.affected_files_cut_off = 60
176 repo_model = RepoModel() 176 repo_model = RepoModel()
177 c.users_array = repo_model.get_users_js() 177 c.users_array = repo_model.get_users_js()
178 c.users_groups_array = repo_model.get_users_groups_js() 178 c.users_groups_array = repo_model.get_users_groups_js()
179 179
180 @LoginRequired() 180 def _index(self, revision, method):
181 @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
182 'repository.admin')
183 def index(self, revision, method='show'):
184 c.anchor_url = anchor_url 181 c.anchor_url = anchor_url
185 c.ignorews_url = _ignorews_url 182 c.ignorews_url = _ignorews_url
186 c.context_url = _context_url 183 c.context_url = _context_url
187 c.fulldiff = fulldiff = request.GET.get('fulldiff') 184 c.fulldiff = fulldiff = request.GET.get('fulldiff')
188 #get ranges of revisions if preset 185 #get ranges of revisions if preset
313 return render('changeset/changeset_range.html') 310 return render('changeset/changeset_range.html')
314 311
315 @LoginRequired() 312 @LoginRequired()
316 @HasRepoPermissionAnyDecorator('repository.read', 'repository.write', 313 @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
317 'repository.admin') 314 'repository.admin')
315 def index(self, revision, method='show'):
316 return self._index(revision, method=method)
317
318 @LoginRequired()
319 @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
320 'repository.admin')
318 def changeset_raw(self, revision): 321 def changeset_raw(self, revision):
319 return self.index(revision, method='raw') 322 return self._index(revision, method='raw')
320 323
321 @LoginRequired() 324 @LoginRequired()
322 @HasRepoPermissionAnyDecorator('repository.read', 'repository.write', 325 @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
323 'repository.admin') 326 'repository.admin')
324 def changeset_patch(self, revision): 327 def changeset_patch(self, revision):
325 return self.index(revision, method='patch') 328 return self._index(revision, method='patch')
326 329
327 @LoginRequired() 330 @LoginRequired()
328 @HasRepoPermissionAnyDecorator('repository.read', 'repository.write', 331 @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
329 'repository.admin') 332 'repository.admin')
330 def changeset_download(self, revision): 333 def changeset_download(self, revision):
331 return self.index(revision, method='download') 334 return self._index(revision, method='download')
332 335
333 @LoginRequired() 336 @LoginRequired()
334 @NotAnonymous() 337 @NotAnonymous()
335 @HasRepoPermissionAnyDecorator('repository.read', 'repository.write', 338 @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
336 'repository.admin') 339 'repository.admin')