comparison rhodecode/model/users_group.py @ 3625:260a7a01b054 beta

follow Python conventions for boolean values True and False might be singletons and the "default" values for "boolean" expressions, but "all" values in Python has a boolean value and should be evaluated as such. Checking with 'is True' and 'is False' is thus confusing, error prone and unnessarily complex. If we anywhere rely and nullable boolean fields from the database layer and don't want the null value to be treated as False then we should check explicitly for null with 'is None'.
author Mads Kiilerich <madski@unity3d.com>
date Thu, 28 Mar 2013 01:10:45 +0100
parents fa6ba6727475
children 10b4e34841a4
comparison
equal deleted inserted replaced
3624:4dddb7ee8865 3625:260a7a01b054
100 100
101 # check if this group is not assigned to repo 101 # check if this group is not assigned to repo
102 assigned_groups = UserGroupRepoToPerm.query()\ 102 assigned_groups = UserGroupRepoToPerm.query()\
103 .filter(UserGroupRepoToPerm.users_group == users_group).all() 103 .filter(UserGroupRepoToPerm.users_group == users_group).all()
104 104
105 if assigned_groups and force is False: 105 if assigned_groups and not force:
106 raise UserGroupsAssignedException('RepoGroup assigned to %s' % 106 raise UserGroupsAssignedException('RepoGroup assigned to %s' %
107 assigned_groups) 107 assigned_groups)
108 108
109 self.sa.delete(users_group) 109 self.sa.delete(users_group)
110 except: 110 except: