Mercurial > kallithea
comparison rhodecode/controllers/feed.py @ 1359:54fc83f2192c beta
Removed all string concat for exchange of ''.join()
author | Marcin Kuzminski <marcin@python-works.com> |
---|---|
date | Sat, 04 Jun 2011 01:16:39 +0200 |
parents | 11548cc19c8f |
children | bf263968da47 89efedac4e6c |
comparison
equal
deleted
inserted
replaced
1358:5ae5aa6b7bed | 1359:54fc83f2192c |
---|---|
50 self.language = 'en-us' | 50 self.language = 'en-us' |
51 self.ttl = "5" | 51 self.ttl = "5" |
52 self.feed_nr = 10 | 52 self.feed_nr = 10 |
53 | 53 |
54 def __changes(self, cs): | 54 def __changes(self, cs): |
55 changes = '' | 55 changes = [] |
56 | 56 |
57 a = [safe_unicode(n.path) for n in cs.added] | 57 a = [safe_unicode(n.path) for n in cs.added] |
58 if a: | 58 if a: |
59 changes += '\nA ' + '\nA '.join(a) | 59 changes.append('\nA ' + '\nA '.join(a)) |
60 | 60 |
61 m = [safe_unicode(n.path) for n in cs.changed] | 61 m = [safe_unicode(n.path) for n in cs.changed] |
62 if m: | 62 if m: |
63 changes += '\nM ' + '\nM '.join(m) | 63 changes.append('\nM ' + '\nM '.join(m)) |
64 | 64 |
65 d = [safe_unicode(n.path) for n in cs.removed] | 65 d = [safe_unicode(n.path) for n in cs.removed] |
66 if d: | 66 if d: |
67 changes += '\nD ' + '\nD '.join(d) | 67 changes.append('\nD ' + '\nD '.join(d)) |
68 | 68 |
69 changes += '</pre>' | 69 changes.append('</pre>') |
70 | 70 |
71 return changes | 71 return ''.join(changes) |
72 | 72 |
73 def atom(self, repo_name): | 73 def atom(self, repo_name): |
74 """Produce an atom-1.0 feed via feedgenerator module""" | 74 """Produce an atom-1.0 feed via feedgenerator module""" |
75 feed = Atom1Feed(title=self.title % repo_name, | 75 feed = Atom1Feed(title=self.title % repo_name, |
76 link=url('summary_home', repo_name=repo_name, | 76 link=url('summary_home', repo_name=repo_name, |
77 qualified=True), | 77 qualified=True), |
78 description=self.description % repo_name, | 78 description=self.description % repo_name, |
79 language=self.language, | 79 language=self.language, |
80 ttl=self.ttl) | 80 ttl=self.ttl) |
81 | 81 desc_msg = [] |
82 for cs in reversed(list(c.rhodecode_repo[-self.feed_nr:])): | 82 for cs in reversed(list(c.rhodecode_repo[-self.feed_nr:])): |
83 desc = '%s - %s<br/><pre>' % (cs.author, cs.date) | 83 desc_msg.append('%s - %s<br/><pre>' % (cs.author, cs.date)) |
84 desc += self.__changes(cs) | 84 desc_msg.append(self.__changes(cs)) |
85 | 85 |
86 feed.add_item(title=cs.message, | 86 feed.add_item(title=cs.message, |
87 link=url('changeset_home', repo_name=repo_name, | 87 link=url('changeset_home', repo_name=repo_name, |
88 revision=cs.raw_id, qualified=True), | 88 revision=cs.raw_id, qualified=True), |
89 author_name=cs.author, | 89 author_name=cs.author, |
90 description=desc) | 90 description=''.join(desc_msg)) |
91 | 91 |
92 response.content_type = feed.mime_type | 92 response.content_type = feed.mime_type |
93 return feed.writeString('utf-8') | 93 return feed.writeString('utf-8') |
94 | 94 |
95 def rss(self, repo_name): | 95 def rss(self, repo_name): |
98 link=url('summary_home', repo_name=repo_name, | 98 link=url('summary_home', repo_name=repo_name, |
99 qualified=True), | 99 qualified=True), |
100 description=self.description % repo_name, | 100 description=self.description % repo_name, |
101 language=self.language, | 101 language=self.language, |
102 ttl=self.ttl) | 102 ttl=self.ttl) |
103 | 103 desc_msg = [] |
104 for cs in reversed(list(c.rhodecode_repo[-self.feed_nr:])): | 104 for cs in reversed(list(c.rhodecode_repo[-self.feed_nr:])): |
105 desc = '%s - %s<br/><pre>' % (cs.author, cs.date) | 105 desc_msg.append('%s - %s<br/><pre>' % (cs.author, cs.date)) |
106 desc += self.__changes(cs) | 106 desc_msg.append(self.__changes(cs)) |
107 | 107 |
108 feed.add_item(title=cs.message, | 108 feed.add_item(title=cs.message, |
109 link=url('changeset_home', repo_name=repo_name, | 109 link=url('changeset_home', repo_name=repo_name, |
110 revision=cs.raw_id, qualified=True), | 110 revision=cs.raw_id, qualified=True), |
111 author_name=cs.author, | 111 author_name=cs.author, |
112 description=desc, | 112 description=''.join(desc_msg), |
113 ) | 113 ) |
114 | 114 |
115 response.content_type = feed.mime_type | 115 response.content_type = feed.mime_type |
116 return feed.writeString('utf-8') | 116 return feed.writeString('utf-8') |