Mercurial > kallithea
comparison rhodecode/templates/pullrequests/pullrequest_show.html @ 3652:8a8a559eaf95 beta
pullrequests: state "closed" explicitly
A closed-as-in-locked icon did not communicate the closed-as-in-inactive state
clearly.
Instead we say "Closed" and make the text greyed out. Not pretty but more
efficient.
author | Mads Kiilerich <madski@unity3d.com> |
---|---|
date | Wed, 03 Apr 2013 15:56:12 +0200 |
parents | 2ea981f9da79 |
children | ec6354949623 |
comparison
equal
deleted
inserted
replaced
3651:659bd922520e | 3652:8a8a559eaf95 |
---|---|
17 <div class="box"> | 17 <div class="box"> |
18 <!-- box / title --> | 18 <!-- box / title --> |
19 <div class="title"> | 19 <div class="title"> |
20 ${self.breadcrumbs()} | 20 ${self.breadcrumbs()} |
21 </div> | 21 </div> |
22 %if c.pull_request.is_closed(): | 22 |
23 <div style="padding:10px; font-size:22px;width:100%;text-align: center; color:#88D882">${_('Closed %s') % (h.age(c.pull_request.updated_on))} ${_('with status %s') % h.changeset_status_lbl(c.current_changeset_status)}</div> | 23 <h3 class="${'closed' if c.pull_request.is_closed() else ''}"> |
24 %endif | 24 <img src="${h.url('/images/icons/flag_status_%s.png' % str(c.pull_request.last_review_status))}" /> |
25 <h3> | 25 ${_('Title')}: ${c.pull_request.title} |
26 %if c.pull_request.is_closed(): | 26 %if c.pull_request.is_closed(): |
27 <img src="${h.url('/images/icons/lock_go.png')}" title="${_('Closed')}"/> | 27 (${_('Closed')}) |
28 %endif | 28 %endif |
29 <img src="${h.url('/images/icons/flag_status_%s.png' % str(c.pull_request.last_review_status))}" /> | 29 </h3> |
30 ${_('Title')}: ${c.pull_request.title}</h3> | |
31 | 30 |
32 <div class="form"> | 31 <div class="form"> |
33 <div id="summary" class="fields"> | 32 <div id="summary" class="fields"> |
34 <div class="field"> | 33 <div class="field"> |
35 <div class="label-summary"> | 34 <div class="label-summary"> |
36 <label>${_('Review status')}:</label> | 35 <label>${_('Review status')}:</label> |
37 </div> | 36 </div> |
38 <div class="input"> | 37 <div class="input"> |
39 <div class="changeset-status-container" style="float:none;clear:both"> | 38 <div class="changeset-status-container" style="float:none;clear:both"> |
40 %if c.current_changeset_status: | 39 %if c.current_changeset_status: |
41 <div title="${_('Pull request status')}" class="changeset-status-lbl">${h.changeset_status_lbl(c.current_changeset_status)}</div> | 40 <div title="${_('Pull request status')}" class="changeset-status-lbl"> |
41 %if c.pull_request.is_closed(): | |
42 ${_('Closed')}, | |
43 %endif | |
44 ${h.changeset_status_lbl(c.current_changeset_status)} | |
45 </div> | |
42 <div class="changeset-status-ico" style="padding:1px 4px"><img src="${h.url('/images/icons/flag_status_%s.png' % c.current_changeset_status)}" /></div> | 46 <div class="changeset-status-ico" style="padding:1px 4px"><img src="${h.url('/images/icons/flag_status_%s.png' % c.current_changeset_status)}" /></div> |
43 %endif | 47 %endif |
44 </div> | 48 </div> |
45 </div> | 49 </div> |
46 </div> | 50 </div> |