Mercurial > kallithea
comparison rhodecode/templates/pullrequests/pullrequest.html @ 3388:cb40b3f6428c beta
review members are dynamically changed based on selected other_repo owner
- implemented pyroutes for smarter JS url handling
- fixed some old style global var routing
author | Marcin Kuzminski <marcin@python-works.com> |
---|---|
date | Wed, 20 Feb 2013 01:59:50 +0100 |
parents | 01fe360a66c0 |
children | f74be3359044 |
comparison
equal
deleted
inserted
replaced
3387:bd5420ea396b | 3388:cb40b3f6428c |
---|---|
65 <li id="reviewer_${member.user_id}"> | 65 <li id="reviewer_${member.user_id}"> |
66 <div class="reviewers_member"> | 66 <div class="reviewers_member"> |
67 <div class="gravatar"><img alt="gravatar" src="${h.gravatar_url(member.email,14)}"/> </div> | 67 <div class="gravatar"><img alt="gravatar" src="${h.gravatar_url(member.email,14)}"/> </div> |
68 <div style="float:left">${member.full_name} (${_('owner')})</div> | 68 <div style="float:left">${member.full_name} (${_('owner')})</div> |
69 <input type="hidden" value="${member.user_id}" name="review_members" /> | 69 <input type="hidden" value="${member.user_id}" name="review_members" /> |
70 <span class="delete_icon action_button" onclick="removeReviewer(${member.user_id})"></span> | 70 <span class="delete_icon action_button" onclick="removeReviewMember(${member.user_id})"></span> |
71 </div> | 71 </div> |
72 </li> | 72 </li> |
73 %endfor | 73 %endfor |
74 </ul> | 74 </ul> |
75 </div> | 75 </div> |
159 } | 159 } |
160 | 160 |
161 ypjax(url,'pull_request_overview', function(data){ | 161 ypjax(url,'pull_request_overview', function(data){ |
162 var sel_box = YUQ('#pull_request_form #other_repo')[0]; | 162 var sel_box = YUQ('#pull_request_form #other_repo')[0]; |
163 var repo_name = sel_box.options[sel_box.selectedIndex].value; | 163 var repo_name = sel_box.options[sel_box.selectedIndex].value; |
164 var _data = other_repos_info[repo_name]; | |
164 YUD.get('pull_request_overview_url').href = url; | 165 YUD.get('pull_request_overview_url').href = url; |
165 YUD.setStyle(YUD.get('pull_request_overview_url').parentElement,'display',''); | 166 YUD.setStyle(YUD.get('pull_request_overview_url').parentElement,'display',''); |
166 YUD.get('other_repo_desc').innerHTML = other_repos_info[repo_name]['description']; | 167 YUD.get('other_repo_desc').innerHTML = other_repos_info[repo_name]['description']; |
167 YUD.get('other_ref').innerHTML = other_repos_info[repo_name]['revs']; | 168 YUD.get('other_ref').innerHTML = other_repos_info[repo_name]['revs']; |
168 // select back the revision that was just compared | 169 // select back the revision that was just compared |
169 setSelectValue(YUD.get('other_ref'), rev_data['other_ref']); | 170 setSelectValue(YUD.get('other_ref'), rev_data['other_ref']); |
171 // reset && add the reviewer based on selected repo | |
172 YUD.get('review_members').innerHTML = ''; | |
173 addReviewMember(_data.user.user_id, _data.user.firstname, | |
174 _data.user.lastname, _data.user.username, | |
175 _data.user.gravatar_link); | |
170 }) | 176 }) |
171 } | 177 } |
172 | 178 |
173 ## refresh automatically when something changes (org_repo can't change) | 179 ## refresh automatically when something changes (org_repo can't change) |
174 | 180 |