diff rhodecode/controllers/journal.py @ 3631:10b4e34841a4 beta

Don't catch all exceptions
author Marcin Kuzminski <marcin@python-works.com>
date Thu, 28 Mar 2013 03:34:36 +0100
parents 0226b6d6b2b5
children 3563bb7b4b82 9d743ca9cede
line wrap: on
line diff
--- a/rhodecode/controllers/journal.py	Thu Mar 28 03:29:38 2013 +0100
+++ b/rhodecode/controllers/journal.py	Thu Mar 28 03:34:36 2013 +0100
@@ -207,7 +207,7 @@
             #filter
             try:
                 journal = _journal_filter(journal, c.search_term)
-            except:
+            except Exception:
                 # we want this to crash for now
                 raise
             journal = journal.filter(filtering_criterion)\
@@ -231,7 +231,7 @@
                                                 self.rhodecode_user.user_id)
                     Session.commit()
                     return 'ok'
-                except:
+                except Exception:
                     raise HTTPBadRequest()
 
             repo_id = request.POST.get('follows_repo_id')
@@ -241,7 +241,7 @@
                                                 self.rhodecode_user.user_id)
                     Session.commit()
                     return 'ok'
-                except:
+                except Exception:
                     raise HTTPBadRequest()
 
         log.debug('token mismatch %s vs %s' % (cur_token, token))