Mercurial > kallithea
diff rhodecode/lib/utils.py @ 3631:10b4e34841a4 beta
Don't catch all exceptions
author | Marcin Kuzminski <marcin@python-works.com> |
---|---|
date | Thu, 28 Mar 2013 03:34:36 +0100 |
parents | 891be8b07407 |
children | 24e24661c0eb |
line wrap: on
line diff
--- a/rhodecode/lib/utils.py Thu Mar 28 03:29:38 2013 +0100 +++ b/rhodecode/lib/utils.py Thu Mar 28 03:34:36 2013 +0100 @@ -166,7 +166,7 @@ (action, safe_unicode(repo), user_obj, ipaddr)) if commit: sa.commit() - except: + except Exception: log.error(traceback.format_exc()) raise @@ -486,7 +486,7 @@ sa.delete(repo) sa.commit() removed.append(repo.repo_name) - except: + except Exception: #don't hold further removals on error log.error(traceback.format_exc()) sa.rollback() @@ -751,7 +751,7 @@ ver = '.'.join(ver.split('.')[:3]) try: _ver = StrictVersion(ver) - except: + except Exception: _ver = StrictVersion('0.0.0') stderr = traceback.format_exc()