diff rhodecode/model/scm.py @ 3631:10b4e34841a4 beta

Don't catch all exceptions
author Marcin Kuzminski <marcin@python-works.com>
date Thu, 28 Mar 2013 03:34:36 +0100
parents 35454cd8233b
children cf65b2c1b69d 3563bb7b4b82
line wrap: on
line diff
--- a/rhodecode/model/scm.py	Thu Mar 28 03:29:38 2013 +0100
+++ b/rhodecode/model/scm.py	Thu Mar 28 03:34:36 2013 +0100
@@ -321,7 +321,7 @@
                               'stopped_following_repo',
                               RepoTemp(follow_repo_id))
                 return
-            except:
+            except Exception:
                 log.error(traceback.format_exc())
                 raise
 
@@ -334,7 +334,7 @@
             action_logger(UserTemp(user_id),
                           'started_following_repo',
                           RepoTemp(follow_repo_id))
-        except:
+        except Exception:
             log.error(traceback.format_exc())
             raise
 
@@ -347,7 +347,7 @@
             try:
                 self.sa.delete(f)
                 return
-            except:
+            except Exception:
                 log.error(traceback.format_exc())
                 raise
 
@@ -356,7 +356,7 @@
             f.user_id = user_id
             f.follows_user_id = follow_user_id
             self.sa.add(f)
-        except:
+        except Exception:
             log.error(traceback.format_exc())
             raise
 
@@ -473,7 +473,7 @@
             else:
                 repo.pull(clone_uri)
             self.mark_for_invalidation(repo_name)
-        except:
+        except Exception:
             log.error(traceback.format_exc())
             raise
 
@@ -658,7 +658,7 @@
                             ver = matches.groups()[0]
                             log.debug('got %s it is rhodecode' % (ver))
                             _rhodecode_hook = True
-                        except:
+                        except Exception:
                             log.error(traceback.format_exc())
             else:
                 # there is no hook in this dir, so we want to create one