Mercurial > kallithea
diff README.rst @ 7726:16df4993b442
scm: don't try to get IP address from web request in model
Remove a layering violation and make functions more reusable when they no
longer depend on global state.
At this level, the IP address (and information about the current user) is only
used for hooks logging push / pull operations. Arguably, IP address logging
only belongs in an HTTP access log, not in the log of push/pull operations. But
as long as we have IP addresses in the logs, we have to provide it. The (good?)
alternative would be to drop IP address from the push / pull logs ...
author | Mads Kiilerich <mads@kiilerich.com> |
---|---|
date | Thu, 10 Jan 2019 23:30:58 +0100 |
parents | b45994c0779e |
children | 5bca0d56a67a |