diff rhodecode/lib/auth.py @ 741:54684e071457 beta

fixes issue #78, ldap makes user validation caseInsensitive and fixed validators to check for case insensitive values.
author Marcin Kuzminski <marcin@python-works.com>
date Tue, 23 Nov 2010 12:58:45 +0100
parents 1bb0fcdec895
children 1377a9d4bdb9
line wrap: on
line diff
--- a/rhodecode/lib/auth.py	Tue Nov 23 01:58:49 2010 +0100
+++ b/rhodecode/lib/auth.py	Tue Nov 23 12:58:45 2010 +0100
@@ -103,6 +103,13 @@
 
 
     else:
+
+        #since ldap is searching in case insensitive check if this user is still
+        #not in our system
+        username = username.lower()
+        if user_model.get_by_username(username, cache=False) is not None:
+            return False 
+        
         from rhodecode.model.settings import SettingsModel
         ldap_settings = SettingsModel().get_ldap_settings()
 
@@ -110,6 +117,7 @@
         # FALLBACK TO LDAP AUTH IN ENABLE                
         #======================================================================
         if ldap_settings.get('ldap_active', False):
+            
             kwargs = {
                   'server':ldap_settings.get('ldap_host', ''),
                   'base_dn':ldap_settings.get('ldap_base_dn', ''),
@@ -214,8 +222,8 @@
 
         #default global
         default_global_perms = sa.query(UserToPerm)\
-            .filter(UserToPerm.user == sa.query(User).filter(User.username ==
-            'default').one())
+            .filter(UserToPerm.user == sa.query(User)\
+                   .filter(User.username == 'default').one())
 
         for perm in default_global_perms:
             user.permissions['global'].add(perm.permission.permission_name)