Mercurial > kallithea
diff rhodecode/lib/helpers.py @ 1359:54fc83f2192c beta
Removed all string concat for exchange of ''.join()
author | Marcin Kuzminski <marcin@python-works.com> |
---|---|
date | Sat, 04 Jun 2011 01:16:39 +0200 |
parents | eec4defdf2b8 |
children | 9c0f5d558789 |
line wrap: on
line diff
--- a/rhodecode/lib/helpers.py Sat Jun 04 00:57:23 2011 +0200 +++ b/rhodecode/lib/helpers.py Sat Jun 04 01:16:39 2011 +0200 @@ -376,12 +376,12 @@ invalidation_list=[]) message = lambda rev: get_changeset_safe(repo, rev).message - - cs_links = " " + ', '.join ([link_to(rev, + cs_links = [] + cs_links.append(" " + ', '.join ([link_to(rev, url('changeset_home', repo_name=repo_name, revision=rev), title=tooltip(message(rev)), - class_='tooltip') for rev in revs[:revs_limit] ]) + class_='tooltip') for rev in revs[:revs_limit] ])) compare_view = (' <div class="compare_view tooltip" title="%s">' '<a href="%s">%s</a> ' @@ -399,23 +399,23 @@ '<a class="show_more" id="_%s" href="#more">%s</a> ' '%s</span>') if not feed: - cs_links += html_tmpl % (_('and'), uniq_id, _('%s more') \ + cs_links.append(html_tmpl % (_('and'), uniq_id, _('%s more') \ % (len(revs) - revs_limit), - _('revisions')) + _('revisions'))) if not feed: html_tmpl = '<span id="%s" style="display:none"> %s </span>' else: html_tmpl = '<span id="%s"> %s </span>' - cs_links += html_tmpl % (uniq_id, ', '.join([link_to(rev, + cs_links.append(html_tmpl % (uniq_id, ', '.join([link_to(rev, url('changeset_home', repo_name=repo_name, revision=rev), title=message(rev), class_='tooltip') - for rev in revs[revs_limit:revs_top_limit]])) + for rev in revs[revs_limit:revs_top_limit]]))) if len(revs) > 1: - cs_links += compare_view - return cs_links + cs_links.append(compare_view) + return ''.join(cs_links) def get_fork_name(): repo_name = action_params