Mercurial > kallithea
diff rhodecode/model/repo.py @ 1749:8ecc6b8229a5 beta
commit less models
- models don't do any commits(with few exceptions)
- all db transactions should be handled by higher level modules like controllers, celery tasks
| author | Marcin Kuzminski <marcin@python-works.com> |
|---|---|
| date | Fri, 02 Dec 2011 22:31:13 +0200 |
| parents | da8ee2ef7f6d |
| children | cf51bbfb120e |
line wrap: on
line diff
--- a/rhodecode/model/repo.py Fri Dec 02 00:15:26 2011 +0200 +++ b/rhodecode/model/repo.py Fri Dec 02 22:31:13 2011 +0200 @@ -204,11 +204,9 @@ # rename repository self.__rename_repo(old=repo_name, new=new_name) - self.sa.commit() return cur_repo except: log.error(traceback.format_exc()) - self.sa.rollback() raise def create(self, form_data, cur_user, just_db=False, fork=False): @@ -312,10 +310,8 @@ try: self.sa.delete(repo) self.__delete_repo(repo) - self.sa.commit() except: log.error(traceback.format_exc()) - self.sa.rollback() raise def delete_perm_user(self, form_data, repo_name): @@ -325,10 +321,8 @@ == self.get_by_repo_name(repo_name))\ .filter(UserRepoToPerm.user_id == form_data['user_id']).one() self.sa.delete(obj) - self.sa.commit() except: log.error(traceback.format_exc()) - self.sa.rollback() raise def delete_perm_users_group(self, form_data, repo_name): @@ -339,10 +333,8 @@ .filter(UsersGroupRepoToPerm.users_group_id == form_data['users_group_id']).one() self.sa.delete(obj) - self.sa.commit() except: log.error(traceback.format_exc()) - self.sa.rollback() raise def delete_stats(self, repo_name): @@ -356,10 +348,8 @@ .filter(Statistics.repository == \ self.get_by_repo_name(repo_name)).one() self.sa.delete(obj) - self.sa.commit() except: log.error(traceback.format_exc()) - self.sa.rollback() raise def __create_repo(self, repo_name, alias, new_parent_id, clone_uri=False): @@ -428,11 +418,11 @@ """ rm_path = os.path.join(self.repos_path, repo.repo_name) log.info("Removing %s", rm_path) - #disable hg/git + # disable hg/git alias = repo.repo_type shutil.move(os.path.join(rm_path, '.%s' % alias), os.path.join(rm_path, 'rm__.%s' % alias)) - #disable repo + # disable repo shutil.move(rm_path, os.path.join(self.repos_path, 'rm__%s__%s' \ % (datetime.today()\ .strftime('%Y%m%d_%H%M%S_%f'),