Mercurial > kallithea
diff CONTRIBUTORS @ 8463:a9bcdc438d69 stable
git: fix pull request deletion - don't crash on deleting refs to PR heads
The refs name was passed as unicode string, and that would cause failure like:
File ".../site-packages/dulwich/repo.py", line 720, in __delitem__
if name.startswith(b"refs/") or name == b"HEAD":
TypeError: startswith first arg must be str or a tuple of str, not bytes
Fixed by correctly passing the ref name as bytes, as we do when creating the PR
refs.
Tests added by Mads Kiilerich.
author | Anton Schur <tonich.sh@gmail.com> |
---|---|
date | Sat, 26 Sep 2020 15:39:33 +0200 |
parents | 143f3e9d7599 |
children | 99ecb5c636fe |
line wrap: on
line diff
--- a/CONTRIBUTORS Sat Sep 26 17:33:18 2020 +0200 +++ b/CONTRIBUTORS Sat Sep 26 15:39:33 2020 +0200 @@ -3,6 +3,7 @@ Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> 2014-2020 Mads Kiilerich <mads@kiilerich.com> 2016-2020 Asterios Dimitriou <steve@pci.gr> 2016-2017 2020 + Anton Schur <tonich.sh@gmail.com> 2017 2020 Private <adamantine.sword@gmail.com> 2019-2020 David Ignjić <ignjic@gmail.com> 2020 Dennis Fink <dennis.fink@c3l.lu> 2020 @@ -41,7 +42,6 @@ Søren Løvborg <sorenl@unity3d.com> 2015-2017 Sam Jaques <sam.jaques@me.com> 2015 2017 Alessandro Molina <alessandro.molina@axant.it> 2017 - Anton Schur <tonich.sh@gmail.com> 2017 Ching-Chen Mao <mao@lins.fju.edu.tw> 2017 Eivind Tagseth <eivindt@gmail.com> 2017 FUJIWARA Katsunori <foozy@lares.dti.ne.jp> 2017