Mercurial > kallithea

diff rhodecode/controllers/changeset.py @ 2439:ad19dfcdb1cc codereview

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Refactoring of changeset_file_comments for more generic usage. In both It enables sharing code between changeset, and pull requests discussions
author Marcin Kuzminski <marcin@python-works.com>
date Sun, 10 Jun 2012 16:44:06 +0200
parents 91fae60bf2b6
children 1bc579bcd67a
line wrap: on
line diff
--- a/rhodecode/controllers/changeset.py	Sun Jun 10 16:39:52 2012 +0200
+++ b/rhodecode/controllers/changeset.py	Sun Jun 10 16:44:06 2012 +0200
@@ -220,10 +220,10 @@
 
             c.comments.extend(ChangesetCommentsModel()\
                               .get_comments(c.rhodecode_db_repo.repo_id,
-                                            changeset.raw_id))
+                                            revision=changeset.raw_id))
             inlines = ChangesetCommentsModel()\
                         .get_inline_comments(c.rhodecode_db_repo.repo_id,
-                                             changeset.raw_id)
+                                             revision=changeset.raw_id)
             c.inline_comments.extend(inlines)
             c.changes[changeset.raw_id] = []
             try:
@@ -295,7 +295,7 @@
                 )
 
         # count inline comments
-        for path, lines in c.inline_comments:
+        for _, lines in c.inline_comments:
             for comments in lines.values():
                 c.inline_cnt += len(comments)