diff kallithea/controllers/admin/repos.py @ 4941:c04c2734e32f

controllers: consistently use formfill.render with force_defaults=False The inconsistency could cause confusion for developers. It seems to me like force_defaults=False should be the default ... and apparently it was that in older versions of formfill. It could perhaps make sense for us to have a wrapper that added the defualt values once, instead of repeating it all over ;-)
author Mads Kiilerich <madski@unity3d.com>
date Wed, 25 Mar 2015 20:38:09 +0100
parents 0bc8975f5365
children 959a9fa7d1a1
line wrap: on
line diff
--- a/kallithea/controllers/admin/repos.py	Wed Mar 25 20:38:09 2015 +0100
+++ b/kallithea/controllers/admin/repos.py	Wed Mar 25 20:38:09 2015 +0100
@@ -155,6 +155,7 @@
                 defaults=errors.value,
                 errors=errors.error_dict or {},
                 prefix_error=False,
+                force_defaults=False,
                 encoding="UTF-8")
 
         except Exception:
@@ -203,8 +204,8 @@
             defaults=defaults,
             errors={},
             prefix_error=False,
-            encoding="UTF-8"
-        )
+            encoding="UTF-8",
+            force_defaults=False)
 
     @LoginRequired()
     @NotAnonymous()
@@ -300,7 +301,8 @@
                 defaults=defaults,
                 errors=errors.error_dict or {},
                 prefix_error=False,
-                encoding="UTF-8")
+                encoding="UTF-8",
+                force_defaults=False)
 
         except Exception:
             log.error(traceback.format_exc())