Mercurial > kallithea
view init.d/kallithea-daemon-redhat @ 8163:24e1099e4f29
py3: make get_current_authuser handle missing tg context consistently and explicitly
tg context handling ends up using
tg.support.registry.StackedObjectProxy._current_obj for attribute access ...
which if no context has been pushed will end up in:
raise TypeError(
'No object (name: %s) has been registered for this '
'thread' % self.____name__)
utils2.get_current_authuser used code like:
if hasattr(tg.tmpl_context, 'authuser'):
Python 2 hasattr will call __getattr__ and return False if it throws any
exception. (It would thus catch the TypeError and silently fall through to use
the default user None.) This hasattr behavior is confusing and hard to use
correctly. Here, it was used incorrectly. It has been common practice to work
around by using something like:
getattr(x, y, None) is not None
Python 3 hasattr fixed this flaw and only catches AttributeError. The TypeError
would thus (rightfully) be propagated. That is a change that must be handled
when introducing py3 support.
The get_current_authuser code could more clearly and simple and py3-compatible
be written as:
return getattr(tmpl_context, 'authuser', None)
- but then we also have to handle the TypeError explicitly ... which we are
happy to do.
author | Mads Kiilerich <mads@kiilerich.com> |
---|---|
date | Fri, 31 Jan 2020 18:48:15 +0100 |
parents | 2c3d30095d5e |
children | 71bdbf129190 |
line wrap: on
line source
#!/bin/sh ######################################## #### THIS IS A REDHAT INIT.D SCRIPT #### ######################################## ################################################## # # Kallithea server startup script # Recommended default-startup: 2 3 4 5 # Recommended default-stop: 0 1 6 # ################################################## APP_NAME="kallithea" # the location of your app # since this is a web app, it should go in /var/www APP_PATH="/var/www/$APP_NAME" CONF_NAME="production.ini" # write to wherever the PID should be stored, just ensure # that the user you run gearbox as has the appropriate permissions # same goes for the log file PID_PATH="/var/run/kallithea/pid" LOG_PATH="/var/log/kallithea/kallithea.log" # replace this with the path to the virtual environment you # made for Kallithea PYTHON_PATH="/opt/python_virtualenvironments/kallithea-venv" RUN_AS="kallithea" DAEMON="$PYTHON_PATH/bin/gearbox" DAEMON_OPTS="serve --daemon \ --user=$RUN_AS \ --group=$RUN_AS \ --pid-file=$PID_PATH \ --log-file=$LOG_PATH -c $APP_PATH/$CONF_NAME" DESC="kallithea-server" LOCK_FILE="/var/lock/subsys/$APP_NAME" # source CentOS init functions . /etc/init.d/functions RETVAL=0 remove_pid () { rm -f ${PID_PATH} rmdir `dirname ${PID_PATH}` } ensure_pid_dir () { PID_DIR=`dirname ${PID_PATH}` if [ ! -d ${PID_DIR} ] ; then mkdir -p ${PID_DIR} chown -R ${RUN_AS}:${RUN_AS} ${PID_DIR} chmod 755 ${PID_DIR} fi } start_kallithea () { ensure_pid_dir PYTHON_EGG_CACHE="/tmp" daemon --pidfile $PID_PATH \ --user $RUN_AS "$DAEMON $DAEMON_OPTS" RETVAL=$? [ $RETVAL -eq 0 ] && touch $LOCK_FILE return $RETVAL } stop_kallithea () { if [ -e $LOCK_FILE ]; then killproc -p $PID_PATH RETVAL=$? rm -f $LOCK_FILE rm -f $PID_PATH else RETVAL=1 fi return $RETVAL } status_kallithea() { if [ -e $LOCK_FILE ]; then # exit with non-zero to indicate failure RETVAL=1 else RETVAL=0 fi return $RETVAL } restart_kallithea () { stop_kallithea start_kallithea RETVAL=$? } case "$1" in start) echo -n $"Starting $DESC: " start_kallithea echo ;; stop) echo -n $"Stopping $DESC: " stop_kallithea echo ;; status) status_kallithea RETVAL=$? if [ ! $RETVAL -eq 0 ]; then echo "Kallithea server is running..." else echo "Kallithea server is stopped." fi ;; restart) echo -n $"Restarting $DESC: " restart_kallithea echo ;; *) echo $"Usage: $0 {start|stop|restart|status}" RETVAL=1 ;; esac exit $RETVAL