Mercurial > kallithea
view init.d/kallithea-daemon-gentoo @ 8286:4aa6a17afc49
validators: don't catch all Exceptions as invalid clone URIs, be specific
When adding a new repository with a remote clone URI, the URI will be
validated in some way. Several exceptions could occur during that
validation.
Previously, the code would catch based on 'Exception', which means that
_any_ exception would cause the URI to be found invalid. This means that
errors in the code (e.g. related to Python 3 conversion) were also
categorized as 'invalid clone URI'. And thus, the tests that test an
actually invalid URI would pass, even though there was a bug.
Now, things have been refactored so it only is relevant to catch
InvalidCloneUriException. Any other exception will now yield a 500 Internal
Server Error, as expected.
author | Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> |
---|---|
date | Sun, 01 Mar 2020 21:40:32 +0100 |
parents | 2c3d30095d5e |
children | 71bdbf129190 |
line wrap: on
line source
#!/sbin/runscript ######################################## #### THIS IS AN GENTOO INIT.D SCRIPT#### ######################################## APP_NAME="kallithea" APP_HOMEDIR="username/python_workspace" APP_PATH="/home/$APP_HOMEDIR/$APP_NAME" CONF_NAME="production.ini" PID_PATH="$APP_PATH/$APP_NAME.pid" LOG_PATH="$APP_PATH/$APP_NAME.log" PYTHON_PATH="/home/$APP_HOMEDIR/v-env" RUN_AS="username" DAEMON="$PYTHON_PATH/bin/gearbox" DAEMON_OPTS="serve --daemon \ --user=$RUN_AS \ --group=$RUN_AS \ --pid-file=$PID_PATH \ --log-file=$LOG_PATH -c $APP_PATH/$CONF_NAME" #extra options opts="${opts} restartdelay" depend() { need nginx } start() { ebegin "Starting $APP_NAME" start-stop-daemon -d $APP_PATH -e PYTHON_EGG_CACHE="/tmp" \ --start --quiet \ --pidfile $PID_PATH \ --user $RUN_AS \ --exec $DAEMON -- $DAEMON_OPTS eend $? } stop() { ebegin "Stopping $APP_NAME" start-stop-daemon -d $APP_PATH \ --stop --quiet \ --pidfile $PID_PATH || echo "$APP_NAME - Not running!" if [ -f $PID_PATH ]; then rm $PID_PATH fi eend $? } restartdelay() { #stop() echo "sleep3" sleep 3 #start() }