Mercurial > kallithea
view scripts/validate-minimum-dependency-versions @ 8908:8993d401575b stable
files: fix raw download of repo files with names with unicode points above 256 in name
Raw download had apparently only been tested with non-ascii characters that
were latin1. That was apparently a (too) simple case that worked without
crashing.
Files with unicode code points above 256 in their name would fail to download,
when Waitress failed like this, trying to get a real byte string by encoding
WSGI headers to latin1:
UnicodeEncodeError: 'latin-1' codec can't encode characters in position 84-85: ordinal not in range(256)
HTTP headers are of course byte strings on the network, but Python3 WSGI does
unfortunately neither expose it as bytes nor as unicode strings to be encoded
as utf-8. Instead, it uses unicode strings with byte values encoded as code
points 0-255. That is achieved by decoding the utf-8 encoded bytes as latin1.
For raw downloads, the recommended download filename is provided in the
Content-Disposition header. The problem is that it was provided as a real
unicode string.
Fixed by applying the "proper" latin1-decoding of a utf8-encoding.
author | Mads Kiilerich <mads@kiilerich.com> |
---|---|
date | Mon, 07 Feb 2022 19:07:08 +0100 |
parents | 01aca0a4f876 |
children | 0a9ddb8cd8c1 |
line wrap: on
line source
#!/bin/bash # Test that installation of all dependencies works fine if versions are set to # the minimum ones. set -e if [ -n "$VIRTUAL_ENV" ]; then echo "This script will create its own virtualenv - please don't run it inside an existing one." >&2 exit 1 fi cd "$(hg root)" venv=build/minimum-dependency-versions-venv log=build/minimum-dependency-versions.log min_requirements=build/minimum-dependency-versions-requirements.txt echo "virtualenv: $venv" echo "log: $log" echo "minimum requirements file: $min_requirements" # clean up previous runs rm -rf "$venv" "$log" mkdir -p "$venv" # Make a light weight parsing of setup.py and dev_requirements.txt, # finding all >= requirements and dumping into a custom requirements.txt # while fixating the requirement at the lower bound. sed -n 's/.*"\(.*\)>=\(.*\)".*/\1==\2/p' setup.py > "$min_requirements" sed 's/>=/==/p' dev_requirements.txt >> "$min_requirements" python3 -m venv "$venv" source "$venv/bin/activate" pip install --upgrade pip setuptools pip install -e . -r "$min_requirements" python-ldap python-pam 2> >(tee "$log" >&2) # Treat any message on stderr as a problem, for the caller to interpret. if [ -s "$log" ]; then echo echo "Error: pip detected following problems:" cat "$log" echo exit 1 fi freeze_txt=build/minimum-dependency-versions.txt pip freeze > $freeze_txt echo "Installation of minimum packages was successful, providing a set of packages as in $freeze_txt . Now running test suite..." pytest echo "Test suite execution was successful." echo "You can now do additional validation using virtual env '$venv'."