Mercurial > kallithea
view scripts/validate-minimum-dependency-versions @ 8751:ad239692ea95
mail: fix duplicate "From" headers
Problem introduced in 9a0c41175e66: When iterating the headers dict and setting
"msg[key] = value", it wasn't replacing the header but performing add_header so
we sometimes ended up with two From headers.
It is also a general problem that while the headers dict only can contain each
key once, it can contain entries that only differ in casing and thus will fold
to the same message header, making it possible to end up adding duplicate
headers.
"msg.replace_header(key, value)" is not a simple solution to the problem: it
will raise KeyError if no such previous key exists.
Now, make the problem more clear by explicitly using add_header.
Avoid the duplication problem by deleting the key (no matter which casing)
before invoking add_header. Delete promises that "No exception is raised if the
named field isn’t present in the headers".
author | Mads Kiilerich <mads@kiilerich.com> |
---|---|
date | Wed, 04 Nov 2020 00:35:21 +0100 |
parents | 01aca0a4f876 |
children | 0a9ddb8cd8c1 |
line wrap: on
line source
#!/bin/bash # Test that installation of all dependencies works fine if versions are set to # the minimum ones. set -e if [ -n "$VIRTUAL_ENV" ]; then echo "This script will create its own virtualenv - please don't run it inside an existing one." >&2 exit 1 fi cd "$(hg root)" venv=build/minimum-dependency-versions-venv log=build/minimum-dependency-versions.log min_requirements=build/minimum-dependency-versions-requirements.txt echo "virtualenv: $venv" echo "log: $log" echo "minimum requirements file: $min_requirements" # clean up previous runs rm -rf "$venv" "$log" mkdir -p "$venv" # Make a light weight parsing of setup.py and dev_requirements.txt, # finding all >= requirements and dumping into a custom requirements.txt # while fixating the requirement at the lower bound. sed -n 's/.*"\(.*\)>=\(.*\)".*/\1==\2/p' setup.py > "$min_requirements" sed 's/>=/==/p' dev_requirements.txt >> "$min_requirements" python3 -m venv "$venv" source "$venv/bin/activate" pip install --upgrade pip setuptools pip install -e . -r "$min_requirements" python-ldap python-pam 2> >(tee "$log" >&2) # Treat any message on stderr as a problem, for the caller to interpret. if [ -s "$log" ]; then echo echo "Error: pip detected following problems:" cat "$log" echo exit 1 fi freeze_txt=build/minimum-dependency-versions.txt pip freeze > $freeze_txt echo "Installation of minimum packages was successful, providing a set of packages as in $freeze_txt . Now running test suite..." pytest echo "Test suite execution was successful." echo "You can now do additional validation using virtual env '$venv'."