Mercurial > kallithea
view scripts/validate-minimum-dependency-versions @ 8276:fdde16d7cea0
celery: fix send_email to work with JSON encoding (Issue #363)
Long time ago, c935bcaf7086 introduced an optional User object parameter to the
send_email task and used the computed full_name_or_username property. Due to the
magic of pickle, that also worked when using Celery to run the task async.
Now, Celery 4 changed the default encoding from Pickle to JSON, which we
anticipated in e539db6cc0da. That broke send_email in some cases, for example
when a user comments on another user's changeset.
Fixed by passing the "From" name as string instead of passing the whole User
object.
Thanks to vyom for reporting.
author | Mads Kiilerich <mads@kiilerich.com> |
---|---|
date | Sat, 29 Feb 2020 16:06:30 +0100 |
parents | 01aca0a4f876 |
children | 0a9ddb8cd8c1 |
line wrap: on
line source
#!/bin/bash # Test that installation of all dependencies works fine if versions are set to # the minimum ones. set -e if [ -n "$VIRTUAL_ENV" ]; then echo "This script will create its own virtualenv - please don't run it inside an existing one." >&2 exit 1 fi cd "$(hg root)" venv=build/minimum-dependency-versions-venv log=build/minimum-dependency-versions.log min_requirements=build/minimum-dependency-versions-requirements.txt echo "virtualenv: $venv" echo "log: $log" echo "minimum requirements file: $min_requirements" # clean up previous runs rm -rf "$venv" "$log" mkdir -p "$venv" # Make a light weight parsing of setup.py and dev_requirements.txt, # finding all >= requirements and dumping into a custom requirements.txt # while fixating the requirement at the lower bound. sed -n 's/.*"\(.*\)>=\(.*\)".*/\1==\2/p' setup.py > "$min_requirements" sed 's/>=/==/p' dev_requirements.txt >> "$min_requirements" python3 -m venv "$venv" source "$venv/bin/activate" pip install --upgrade pip setuptools pip install -e . -r "$min_requirements" python-ldap python-pam 2> >(tee "$log" >&2) # Treat any message on stderr as a problem, for the caller to interpret. if [ -s "$log" ]; then echo echo "Error: pip detected following problems:" cat "$log" echo exit 1 fi freeze_txt=build/minimum-dependency-versions.txt pip freeze > $freeze_txt echo "Installation of minimum packages was successful, providing a set of packages as in $freeze_txt . Now running test suite..." pytest echo "Test suite execution was successful." echo "You can now do additional validation using virtual env '$venv'."