# HG changeset patch # User Thomas De Schampheleire # Date 1525204314 -7200 # Node ID 1bdda21f186a951d3dbface660ee732ed58eb019 # Parent ca4b2c3c2ffbf9d2b518001f9866211e9de8541f repo-scan: don't print empty list of results If 'gearbox repo-scan' does not add nor remove anything, the output is: Now scanning root location for new repos ... Scan completed. Added: - Missing: - These empty lists of results are not very helpful. Instead, rework the code so that a list of added/removed/missing repositories is only printed if it actually contains something. diff -r ca4b2c3c2ffb -r 1bdda21f186a kallithea/lib/paster_commands/repo_scan.py --- a/kallithea/lib/paster_commands/repo_scan.py Mon Apr 23 01:02:07 2018 +0200 +++ b/kallithea/lib/paster_commands/repo_scan.py Tue May 01 21:51:54 2018 +0200 @@ -46,14 +46,12 @@ print 'Now scanning root location for new repos ...' added, removed = repo2db_mapper(ScmModel().repo_scan(), remove_obsolete=rm_obsolete) - added = ', '.join(added) or '-' - removed = ', '.join(removed) or '-' print 'Scan completed.' - print 'Added: %s' % added - if rm_obsolete: - print 'Removed: %s' % removed - else: - print 'Missing: %s' % removed + if added: + print 'Added: %s' % ', '.join(added) + if removed: + print '%s: %s' % ('Removed' if rm_obsolete else 'Missing', + ', '.join(removed)) def get_parser(self, prog_name): parser = super(Command, self).get_parser(prog_name)