# HG changeset patch # User Thomas De Schampheleire # Date 1517991854 -3600 # Node ID 4086efa27652a0883e0194533fcd52edcabd13ba # Parent f028c24a714dfeedbd5562bda8978c0d94c8b706 tests: notification: clarify that cs_target_repo is a URL In analogy with the fake URLs used for pullrequest notification testing, use an URL for cs_target_repo. When testing the resulting HTML in a real email client, it will become obvious that the mail client transforms URLs to something clickable, regardless of any present tag. diff -r f028c24a714d -r 4086efa27652 kallithea/tests/models/test_dump_html_mails.ref.html --- a/kallithea/tests/models/test_dump_html_mails.ref.html Sat Feb 03 22:01:46 2018 +0100 +++ b/kallithea/tests/models/test_dump_html_mails.ref.html Wed Feb 07 09:24:14 2018 +0100 @@ -22,7 +22,7 @@ - and here it ends indented. -Changeset on repo_target branch brunch: +Changeset on http://example.com/repo_target branch brunch: "This changeset did something clever which is hard to explain" by u2 u3 (u2). @@ -112,7 +112,7 @@
Changeset on repo_target + href="http://example.com/repo_target">http://example.com/repo_target branch brunch:
@@ -181,7 +181,7 @@ - and here it ends indented. -Changeset on repo_target branch brunch: +Changeset on http://example.com/repo_target branch brunch: "This changeset did something clever which is hard to explain" by u2 u3 (u2). @@ -271,7 +271,7 @@
Changeset on repo_target + href="http://example.com/repo_target">http://example.com/repo_target branch brunch:
@@ -342,7 +342,7 @@ - and here it ends indented. -Changeset on repo_target branch brunch: +Changeset on http://example.com/repo_target branch brunch: "This changeset did something clever which is hard to explain" by u2 u3 (u2). @@ -448,7 +448,7 @@
Changeset on repo_target + href="http://example.com/repo_target">http://example.com/repo_target branch brunch:
@@ -519,7 +519,7 @@ - and here it ends indented. -Changeset on repo_target branch brunch: +Changeset on http://example.com/repo_target branch brunch: "This changeset did something clever which is hard to explain" by u2 u3 (u2). @@ -625,7 +625,7 @@
Changeset on repo_target + href="http://example.com/repo_target">http://example.com/repo_target branch brunch:
diff -r f028c24a714d -r 4086efa27652 kallithea/tests/models/test_notifications.py --- a/kallithea/tests/models/test_notifications.py Sat Feb 03 22:01:46 2018 +0100 +++ b/kallithea/tests/models/test_notifications.py Wed Feb 07 09:24:14 2018 +0100 @@ -220,7 +220,7 @@ message='This changeset did something clever which is hard to explain', message_short='This changeset did something cl...', status_change=[None, 'Approved'], - cs_target_repo='repo_target', + cs_target_repo='http://example.com/repo_target', cs_url='http://changeset.com', cs_author=User.get(self.u2))), (Notification.TYPE_MESSAGE,