# HG changeset patch # User Mads Kiilerich # Date 1528115197 -7200 # Node ID 4707d09d49a6b1d15eef5d76e07026c807243ebf # Parent 1d5145d52c30fd618cc23e3ba227939d3e0e6c4d repos: make edit_permissions_revoke controller return an actual (empty) body on success The code 204 was slightly confusing even though technically OK. diff -r 1d5145d52c30 -r 4707d09d49a6 kallithea/controllers/admin/repos.py --- a/kallithea/controllers/admin/repos.py Thu Jun 07 01:48:15 2018 +0200 +++ b/kallithea/controllers/admin/repos.py Mon Jun 04 14:26:37 2018 +0200 @@ -355,6 +355,7 @@ h.flash(_('An error occurred during revoking of permission'), category='error') raise HTTPInternalServerError() + return [] @HasRepoPermissionLevelDecorator('admin') def edit_fields(self, repo_name): diff -r 1d5145d52c30 -r 4707d09d49a6 kallithea/tests/functional/test_admin_permissions.py --- a/kallithea/tests/functional/test_admin_permissions.py Thu Jun 07 01:48:15 2018 +0200 +++ b/kallithea/tests/functional/test_admin_permissions.py Mon Jun 04 14:26:37 2018 +0200 @@ -125,5 +125,5 @@ obj_type='user', user_id=user.user_id, _authentication_token=self.authentication_token()), - status=204) # success has no content + status=200) assert not response.body