# HG changeset patch # User Marcin Kuzminski # Date 1364406876 -3600 # Node ID 50927aedcab50587acc1627b2d648006437383cb # Parent e8db9fe4cca3f5ab5ef792e638e3dc00eb052d94 move the existing changeset checks bellow other checks else it can throw exceptions for non existing repos diff -r e8db9fe4cca3 -r 50927aedcab5 rhodecode/controllers/compare.py --- a/rhodecode/controllers/compare.py Wed Mar 27 18:50:25 2013 +0100 +++ b/rhodecode/controllers/compare.py Wed Mar 27 18:54:36 2013 +0100 @@ -115,9 +115,6 @@ org_repo = Repository.get_by_repo_name(org_repo) other_repo = Repository.get_by_repo_name(other_repo) - self.__get_cs_or_redirect(rev=org_ref, repo=org_repo, partial=partial) - self.__get_cs_or_redirect(rev=other_ref, repo=other_repo, partial=partial) - if org_repo is None: log.error('Could not find org repo %s' % org_repo) raise HTTPNotFound @@ -133,6 +130,9 @@ log.error('compare of two different kind of remote repos not available') raise HTTPNotFound + self.__get_cs_or_redirect(rev=org_ref, repo=org_repo, partial=partial) + self.__get_cs_or_redirect(rev=other_ref, repo=other_repo, partial=partial) + c.org_repo = org_repo c.other_repo = other_repo c.org_ref = org_ref[1]