# HG changeset patch # User Thomas De Schampheleire # Date 1435261054 -7200 # Node ID 51e761fc65d624260ff36458211e6a12c28baf8e # Parent 3cfa0a577f5a8f56dd21ab631ac20cb377a8f942 autocomplete: increase reuse of gravatar logic By splitting autocompleteGravatar in a first part that returns the core gravatar html code, we can remove yet some more duplication. Hooray! diff -r 3cfa0a577f5a -r 51e761fc65d6 kallithea/public/js/base.js --- a/kallithea/public/js/base.js Thu Jun 25 21:15:46 2015 +0200 +++ b/kallithea/public/js/base.js Thu Jun 25 21:37:34 2015 +0200 @@ -1157,11 +1157,16 @@ + "" + full.substring(matchindex + snippet.length); }; -var autocompleteGravatar = function(res, link, size, group) { - var elem = 'gravatar'.format(size, link); +var gravatar = function(link, size, cssclass) { + var elem = 'gravatar'.format(size, link, cssclass); if (!link) { - elem = ''.format(size); + elem = ''.format(size, cssclass); } + return elem; +} + +var autocompleteGravatar = function(res, link, size, group) { + var elem = gravatar(link, size, "perm-gravatar-ac"); if (group !== undefined) { elem = ''; } @@ -1439,9 +1444,7 @@ var addReviewMember = function(id,fname,lname,nname,gravatar_link,gravatar_size){ var displayname = "{0} {1}".format(fname, lname); - var gravatarelm = 'gravatar'.format(gravatar_size, gravatar_link); - if (!gravatar_link) - gravatarelm = ''.format(gravatar_size); + var gravatarelm = gravatar(gravatar_link, gravatar_size, ""); // WARNING: the HTML below is duplicate with // kallithea/templates/pullrequests/pullrequest_show.html // If you change something here it should be reflected in the template too.