# HG changeset patch # User Mads Kiilerich # Date 1470313416 -7200 # Node ID 5e836bd9b5d46d0786781d2179310e19df678845 # Parent 74f880bfcb7bfe12d6b904ce705f7c24bc942fef routing: introduce 'edit_user_emails_delete' url and use POST instead of DELETE diff -r 74f880bfcb7b -r 5e836bd9b5d4 kallithea/config/routing.py --- a/kallithea/config/routing.py Thu Aug 04 14:23:36 2016 +0200 +++ b/kallithea/config/routing.py Thu Aug 04 14:23:36 2016 +0200 @@ -205,8 +205,8 @@ action="edit_emails", conditions=dict(method=["GET"])) m.connect("edit_user_emails", "/users/{id}/edit/emails", action="add_email", conditions=dict(method=["PUT"])) - m.connect("edit_user_emails", "/users/{id}/edit/emails", - action="delete_email", conditions=dict(method=["DELETE"])) + m.connect("edit_user_emails_delete", "/users/{id}/edit/emails/delete", + action="delete_email", conditions=dict(method=["POST"])) m.connect("edit_user_ips", "/users/{id}/edit/ips", action="edit_ips", conditions=dict(method=["GET"])) diff -r 74f880bfcb7b -r 5e836bd9b5d4 kallithea/templates/admin/users/user_edit_emails.html --- a/kallithea/templates/admin/users/user_edit_emails.html Thu Aug 04 14:23:36 2016 +0200 +++ b/kallithea/templates/admin/users/user_edit_emails.html Thu Aug 04 14:23:36 2016 +0200 @@ -17,7 +17,7 @@ %endif
${em.email}
- ${h.form(url('edit_user_emails', id=c.user.user_id),method='delete')} + ${h.form(url('edit_user_emails_delete', id=c.user.user_id))} ${h.hidden('del_email_id',em.email_id)} ${h.submit('remove_',_('Delete'),id="remove_email_%s" % em.email_id, diff -r 74f880bfcb7b -r 5e836bd9b5d4 kallithea/tests/functional/test_admin_users.py --- a/kallithea/tests/functional/test_admin_users.py Thu Aug 04 14:23:36 2016 +0200 +++ b/kallithea/tests/functional/test_admin_users.py Thu Aug 04 14:23:36 2016 +0200 @@ -587,8 +587,8 @@ def test_delete_emails_default_user(self): self.log_user() user = User.get_default_user() - response = self.app.post(url('edit_user_emails', id=user.user_id), - {'_method': 'delete', '_authentication_token': self.authentication_token()}, status=404) + response = self.app.post(url('edit_user_emails_delete', id=user.user_id), + {'_authentication_token': self.authentication_token()}, status=404) # IP addresses # Add/delete of IP addresses for the default user is used to maintain