# HG changeset patch
# User Jim Hague <jim.hague@acm.org>
# Date 1405597676 -3600
# Node ID 805ec49152c9aa02a321d6c0692a680a338d6ba6
# Parent  29a5a16e33847b03388975879651092ae74144c7
simplehg: don't quiet Hg output for push

I want to be able to see informational messages from e.g. the Hg Bugzilla
extension.

Here's output without the patch. This is identical to the output produced if
the Bugzilla extension is disabled:

remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: Repository size .hg:158.2 kB repo:0 B total:158.2 kB
remote: Last revision is now r324:6c03abbabb46

and with the patch:

remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: Repository size .hg:158.2 kB repo:0 B total:158.2 kB
remote: Last revision is now r324:6c03abbabb46
remote: bug 3270 already knows about changeset 6c03abbabb46

The last line indicates that the Bugzilla bug text already contains an entry
for that changeset. It's produced by a call to self.ui.status() in the
extension.

I think the point here is that the deleted code is ensuring that the remote hg
(i.e. the Kallithea hg) always runs with the --quiet flag when receiving a
push. This seems an arbitrary decision to me, and one that removes potentially
useful information from the output. I believe this behaviour is different to
that seen by the user if pushing to hgweb (I've not tried it, but inspected the
hgweb source for setting quiet) and is certainly different to pushing over ssh.

diff -r 29a5a16e3384 -r 805ec49152c9 kallithea/lib/middleware/simplehg.py
--- a/kallithea/lib/middleware/simplehg.py	Thu Oct 02 23:49:16 2014 +0200
+++ b/kallithea/lib/middleware/simplehg.py	Thu Jul 17 12:47:56 2014 +0100
@@ -284,9 +284,6 @@
 
         hgrc = os.path.join(repo_path, '.hg', 'hgrc')
 
-        # make our hgweb quiet so it doesn't print output
-        baseui.setconfig('ui', 'quiet', 'true')
-
         repoui = make_ui('file', hgrc, False)
 
         if repoui: