# HG changeset patch # User Mads Kiilerich # Date 1439289547 -7200 # Node ID 99d29f43bdd18fb8a490aa1666b84864b0a115e9 # Parent 144878118c956f58394617e8856df2a833d76318 comments: bind comment-bubble click handler to table and use sub selector Avoid jQuery looping over all lines and binding comment-bubble click handler to every line on page load. Avoids 'Maximum call stack size exceeded' when loading a huge diff in Chrome. diff -r 144878118c95 -r 99d29f43bdd1 kallithea/templates/changeset/changeset.html --- a/kallithea/templates/changeset/changeset.html Tue Aug 11 12:39:07 2015 +0200 +++ b/kallithea/templates/changeset/changeset.html Tue Aug 11 12:39:07 2015 +0200 @@ -224,7 +224,7 @@ } }); - $('.add-bubble').click(function(e){ + $('.code-difftable').on('click', '.add-bubble', function(e){ show_comment_form($(this)); }); diff -r 144878118c95 -r 99d29f43bdd1 kallithea/templates/pullrequests/pullrequest_show.html --- a/kallithea/templates/pullrequests/pullrequest_show.html Tue Aug 11 12:39:07 2015 +0200 +++ b/kallithea/templates/pullrequests/pullrequest_show.html Tue Aug 11 12:39:07 2015 +0200 @@ -376,7 +376,7 @@ $(document).ready(function(){ PullRequestAutoComplete('user', 'reviewers_container', _USERS_AC_DATA); - $('.add-bubble').click(function(e){ + $('.code-difftable').on('click', '.add-bubble', function(e){ show_comment_form($(this)); });